Closed Bug 1495341 Opened 1 year ago Closed 1 year ago

Place Web Replay menu items in their own submenu

Categories

(Core :: Web Replay, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: bhackett1024, Assigned: bhackett1024)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
The attached patch removes the separate Web Replay menu items under the 'Web Developer' menu and adds a submenu containing those menu items.  Associated code has also been reorganized to consolidate things in the new devtools/client/webreplay folder.
Attachment #9013197 - Flags: review?(jlaster)
Attached image screen shot
Screen shot of new menu, with bonus 'Reload and Record Tab' item to be added shortly in another bug.
Blocks: 1495342
Nice!

- I think I prefer "Load recording" over "New replaying tab" as it is parallel with "Save recording". 
- I wonder if "New recording tab" needs a verb like "Open new recording tab"
Attached patch patchSplinter Review
Updated patch, I went with 'Open New Recording Tab' and 'Load Recording in New Tab' to make sure things are clear.
Attachment #9013197 - Attachment is obsolete: true
Attachment #9013197 - Flags: review?(jlaster)
Attachment #9013317 - Flags: review?(jlaster)
Attachment #9013317 - Flags: review?(jlaster) → review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a14e1d156c61
Place Web Replay menu items in their own submenu, r=jlast.
https://hg.mozilla.org/mozilla-central/rev/a14e1d156c61
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Depends on: 1496138
You need to log in before you can comment on or make changes to this bug.