1495379 - fails to build due recent change in cranelift build script

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Dan Horák]

FF, Javascript respectively, fails to build on ppc64/ppc64le/s390x (and other not white-listed ones) after a recent change from bug 1490948 in the js/src/wasm/cranelift/build.rs build script (https://hg.mozilla.org/mozilla-central/rev/2225cbe1f042).

...
   Compiling cranelift-wasm v0.20.1
   Compiling baldrdash v0.1.0 (file:///home/jenkins/workspace/Firefox-default/label/s390x/firefox/js/src/wasm/cranelift)
error: failed to run custom build command for `baldrdash v0.1.0 (file:///home/jenkins/workspace/Firefox-default/label/s390x/firefox/js/src/wasm/cranelift)`
process didn't exit successfully: `/home/jenkins/workspace/Firefox-default/label/s390x/firefox/obj-s390x-ibm-linux-gnu/js/src/rust/release/build/baldrdash-5f7e9e7e77af924b/build-script-build` (exit code: 101)
--- stdout
cargo:rerun-if-changed=baldrapi.h
--- stderr
thread 'main' panicked at 'unknown arch', js/src/wasm/cranelift/build.rs:62:18


Couldn't the the arch list be limited to Android/Windows only?

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Thanks for the bug report! I'll propose a fix to ignore some tier 3 platforms.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: fix.patch

Dan, can you please try this patch and let me know if it addresses your issue? Thanks!

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 9013252 [details] [diff] [review]
fix.patch

Review of attachment 9013252 [details] [diff] [review]:
-----------------------------------------------------------------

I can see how this patch fixes the build error.  Is it going to work at runtime as well, that is, we're not going to try and run cranelift for unsupported architectures?

Comment 4

[Dan Horák]

yes, it does fix the problem

Comment 5

[Benjamin Bouvier [:bbouvier] (inactive)]

(In reply to Nathan Froyd [:froydnj] from comment #3)
> Comment on attachment 9013252 [details] [diff] [review]
> fix.patch
> 
> Review of attachment 9013252 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I can see how this patch fixes the build error.  Is it going to work at
> runtime as well, that is, we're not going to try and run cranelift for
> unsupported architectures?

There's a runtime guard at the moment that will throw a JS error at runtime when the architecture is not supported by Cranelift.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a47ef2cd552d
Don't unnecessarily abort Cranelift builds on unknown architectures; r=froydnj

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/a47ef2cd552d