1495388 - Make inspector front instantiation async

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

Toolbox currently handles inspector-related fronts instantiation and destruction:
  https://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox.js#2654-2683
  https://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox.js#2729-2781

Most of this code should be moved to the front class.
The toolbox should most likely only register its event listener and that's it:
  this._selection.on("new-node-front", this._onNewSelectedNodeFront);

  if (this.highlighterUtils.isRemoteHighlightable()) {
    this.walker.on("highlighter-ready", this._highlighterReady);
    this.walker.on("highlighter-hide", this._highlighterHidden);
  }

Moving the initialization code to the front will depend on bug 1495387, while still being able to listen for events will depend on bug 1495386.

Comment 1

[Yulia Startsev [:yulia]]

Attachment: Bug 1495388 - Make Inspector Front destruction async, and handled within the front; r=ochameau

this introduces all of the required methods for destruction directly into the front.

Depends on D8707

Comment 2

[Yulia Startsev [:yulia]]

Attachment: Bug 1495388 - Make Inspector Front initialization async; r=ochameau

Comment 3

[Yulia Startsev [:yulia]]

Attachment: Bug 1495388 - Fix test failures associated with async inspector initalization; r=ochameau

Depends on D8707

Comment 4

[Yulia Startsev [:yulia]]

Attachment: Bug 1495388 - fix test case i hope?; r=ochameau

Depends on D8708

Comment 5

[Yulia Startsev [:yulia]]

try run for initialization: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=206315139&revision=6efacf2677edf26ba23a54e03060319513b1570a

Comment 6

[Yulia Startsev [:yulia]]

Attachment: Bug 1495388 - Simplify Inspector Front destruction; r=ochameau

Depends on D8992

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6a9327272cb
Make Inspector Front initialization async; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/34be7319a9f0
Fix test failures associated with async inspector initalization; r=ochameau

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/f6a9327272cb
https://hg.mozilla.org/mozilla-central/rev/34be7319a9f0

Comment 9

[Yulia Startsev [:yulia]]

reopening for the destructor code.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78ec5e67a3a6
Simplify Inspector Front destruction; r=ochameau

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/78ec5e67a3a6