Closed Bug 1495388 Opened 2 years ago Closed 2 years ago

Make inspector front instantiation async

Categories

(DevTools :: Inspector, enhancement, P2)

enhancement

Tracking

(firefox65 fixed)

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: ochameau, Assigned: yulia)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission)

Attachments

(3 files, 2 obsolete files)

Toolbox currently handles inspector-related fronts instantiation and destruction:
  https://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox.js#2654-2683
  https://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox.js#2729-2781

Most of this code should be moved to the front class.
The toolbox should most likely only register its event listener and that's it:
  this._selection.on("new-node-front", this._onNewSelectedNodeFront);

  if (this.highlighterUtils.isRemoteHighlightable()) {
    this.walker.on("highlighter-ready", this._highlighterReady);
    this.walker.on("highlighter-hide", this._highlighterHidden);
  }

Moving the initialization code to the front will depend on bug 1495387, while still being able to listen for events will depend on bug 1495386.
Severity: normal → enhancement
Priority: -- → P2
Summary: Remove inspector-related front speficics out of toolbox class → Remove inspector-related front specifics out of toolbox class
this introduces all of the required methods for destruction directly into the front.

Depends on D8707
Depends on D8708
Assignee: nobody → ystartsev
Attachment #9017927 - Attachment is obsolete: true
Attachment #9017899 - Attachment is obsolete: true
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6a9327272cb
Make Inspector Front initialization async; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/34be7319a9f0
Fix test failures associated with async inspector initalization; r=ochameau
https://hg.mozilla.org/mozilla-central/rev/f6a9327272cb
https://hg.mozilla.org/mozilla-central/rev/34be7319a9f0
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Whiteboard: dt-fission
reopening for the destructor code.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: 1503562
Summary: Remove inspector-related front specifics out of toolbox class → Make inspector front instantiation async
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/78ec5e67a3a6
Simplify Inspector Front destruction; r=ochameau
https://hg.mozilla.org/mozilla-central/rev/78ec5e67a3a6
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.