Make inspector front instantiation async

RESOLVED FIXED in Firefox 65

Status

P2
enhancement
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: ochameau, Assigned: yulia)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 65
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

(Whiteboard: dt-fission)

Attachments

(3 attachments, 2 obsolete attachments)

(Reporter)

Description

5 months ago
Toolbox currently handles inspector-related fronts instantiation and destruction:
  https://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox.js#2654-2683
  https://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox.js#2729-2781

Most of this code should be moved to the front class.
The toolbox should most likely only register its event listener and that's it:
  this._selection.on("new-node-front", this._onNewSelectedNodeFront);

  if (this.highlighterUtils.isRemoteHighlightable()) {
    this.walker.on("highlighter-ready", this._highlighterReady);
    this.walker.on("highlighter-hide", this._highlighterHidden);
  }

Moving the initialization code to the front will depend on bug 1495387, while still being able to listen for events will depend on bug 1495386.
(Reporter)

Updated

5 months ago
Severity: normal → enhancement
Priority: -- → P2
Summary: Remove inspector-related front speficics out of toolbox class → Remove inspector-related front specifics out of toolbox class
(Assignee)

Comment 1

4 months ago
Created attachment 9017899 [details]
Bug 1495388 - Make Inspector Front destruction async, and handled within the front; r=ochameau

this introduces all of the required methods for destruction directly into the front.

Depends on D8707
(Assignee)

Comment 2

4 months ago
Created attachment 9017900 [details]
Bug 1495388 - Make Inspector Front initialization async; r=ochameau
(Assignee)

Comment 3

4 months ago
Created attachment 9017908 [details]
Bug 1495388 - Fix test failures associated with async inspector initalization; r=ochameau

Depends on D8707
(Assignee)

Comment 4

4 months ago
Created attachment 9017927 [details]
Bug 1495388 - fix test case i hope?; r=ochameau

Depends on D8708
(Reporter)

Updated

4 months ago
Assignee: nobody → ystartsev
Attachment #9017927 - Attachment is obsolete: true
(Assignee)

Comment 6

4 months ago
Created attachment 9018302 [details]
Bug 1495388 - Simplify Inspector Front destruction; r=ochameau

Depends on D8992
Attachment #9017899 - Attachment is obsolete: true

Comment 7

4 months ago
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6a9327272cb
Make Inspector Front initialization async; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/34be7319a9f0
Fix test failures associated with async inspector initalization; r=ochameau

Comment 8

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f6a9327272cb
https://hg.mozilla.org/mozilla-central/rev/34be7319a9f0
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Whiteboard: dt-fission
(Assignee)

Comment 9

4 months ago
reopening for the destructor code.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

4 months ago
Blocks: 1503562
Summary: Remove inspector-related front specifics out of toolbox class → Make inspector front instantiation async

Comment 10

4 months ago
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/78ec5e67a3a6
Simplify Inspector Front destruction; r=ochameau

Comment 11

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/78ec5e67a3a6
Status: REOPENED → RESOLVED
Last Resolved: 4 months ago4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.