1495389 - Remove performance front specifics out of toolbox class

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P3)

Description

[Alexandre Poirot [:ochameau]]

Toolbox currently handles performance front instantiation and destruction:
  https://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox.js#3026-3074

Most of this code should be moved to the front class.
The toolbox should only register its event listener and that's it:
  this.performance.on("*", this._onPerformanceFrontEvent);

Moving the initialization code to the front will depend on bug 1495387, while still being able to listen for events will depend on bug 1495386.

Comment 1

[Yulia Startsev [:yulia]]

Attachment: Bug 1495389 - add test for expected async behavior in the performance front; r=ochameau

Comment 2

[Yulia Startsev [:yulia]]

Attachment: Bug 1495389 - remove unused event; r=ochameau

Comment 3

[Yulia Startsev [:yulia]]

Attachment: Bug 1495389 - adjust test to use new performance front initialization; r=ochameau

Depends on D10564

Comment 4

[Yulia Startsev [:yulia]]

Attachment: Bug 1495389 - refactor toolbox to no longer queue performance events; r=ochameau

Depends on D11293

Comment 5

[Yulia Startsev [:yulia]]

Attachment: Bug 1495389 - remove destroy method for performance actor; r=ochameau

Depends on D11294

Comment 6

[Yulia Startsev [:yulia]]

Attachment: Bug 1495389 - remove instances of toolbox.performance; r=ochameau

Depends on D11295

Comment 7

[Yulia Startsev [:yulia]]

Attachment: Bug 1495389 - remove performance front from the toolbox completely; r=ochameau

Depends on D11296

Comment 8

[Yulia Startsev [:yulia]]

Attachment: Bug 1495389 - bring back populateWithRecordings to toolbox; r=ochameau

This returns the old behavior of populating the performanceController with recordings from the
toolbox. This is based on a comment that alex made regarding "console-profile-start" being intrinsic
to the toolbox. This is an optional revision

Depends on D11296

Comment 9

[Yulia Startsev [:yulia]]

Attachment: Bug 1495389 - introduce checks for async fronts in target; r=ochameau

This introduces some more logic to how async fronts are managed in the target. At some point this
will need to be ported to protocol.js' marshalling methods

Comment 10

[Yulia Startsev [:yulia]]

Attachment: Bug 1495389 - migrate togglePicker to nodePicker; r=ochameau

Depends on D12119

Comment 11

[Yulia Startsev [:yulia]]

Attachment: Bug 1495389 - migrate startPicker and stopPicker to nodePicker; r=ochameau

Depends on D12122

Comment 12

[Yulia Startsev [:yulia]]

Attachment: bug 1495389 - migrate node picking methods to NodePicker module, and use it through the inspector; r=ochameau

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4e9eae1c922
add test for expected async behavior in the performance front; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/b9ef729af807
adjust test to use new performance front initialization; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/854746ccad9c
refactor toolbox to no longer queue performance events; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/b7b8fe847021
remove destroy method for performance actor; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/4d740f3060ce
remove instances of toolbox.performance; r=ochameau

Comment 14

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c4e9eae1c922
https://hg.mozilla.org/mozilla-central/rev/b9ef729af807
https://hg.mozilla.org/mozilla-central/rev/854746ccad9c
https://hg.mozilla.org/mozilla-central/rev/b7b8fe847021
https://hg.mozilla.org/mozilla-central/rev/4d740f3060ce