Closed
Bug 1495397
Opened 6 years ago
Closed 6 years ago
Update mozilla-central's package.json to be more generic, and move existing ESLint modules to dev dependencies
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox64 fixed)
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Currently our top-level package.json is very ESLint specific and has the ESLint dependencies as production dependencies.
As we're starting to vendor our node_modules dependencies (bug 1491021), I think we should be making the package.json more generic, and swap the ESLint dependencies to dev dependencies. Then, as we add more packages it will provide a clearer separation between what is built into Firefox, versus what is build/test infra.
Splitting this out from bug 1491028, as I think it would be best to do it ahead of landing any node_modules.
Assignee | ||
Updated•6 years ago
|
Summary: Update mozilla-central's package.json to be more generic, and move existing ESLint modules to dev dependencies. → Update mozilla-central's package.json to be more generic, and move existing ESLint modules to dev dependencies
Assignee | ||
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9013260 [details]
Bug 1495397 - Update mozilla-central's package.json for being more generic, and move existing ESLint modules to dev dependencies.
Nick Alexander :nalexander [he/him] has approved the revision.
Attachment #9013260 -
Flags: review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ef2bffa13bc
Update mozilla-central's package.json for being more generic, and move existing ESLint modules to dev dependencies. r=firefox-build-system-reviewers,nalexander
Comment 4•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•