Update mozilla-central's package.json to be more generic, and move existing ESLint modules to dev dependencies

RESOLVED FIXED in Firefox 64

Status

enhancement
RESOLVED FIXED
10 months ago
2 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

(Blocks 1 bug)

Trunk
mozilla64
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

Currently our top-level package.json is very ESLint specific and has the ESLint dependencies as production dependencies.

As we're starting to vendor our node_modules dependencies (bug 1491021), I think we should be making the package.json more generic, and swap the ESLint dependencies to dev dependencies. Then, as we add more packages it will provide a clearer separation between what is built into Firefox, versus what is build/test infra.

Splitting this out from bug 1491028, as I think it would be best to do it ahead of landing any node_modules.
Summary: Update mozilla-central's package.json to be more generic, and move existing ESLint modules to dev dependencies. → Update mozilla-central's package.json to be more generic, and move existing ESLint modules to dev dependencies
Comment on attachment 9013260 [details]
Bug 1495397 - Update mozilla-central's package.json for being more generic, and move existing ESLint modules to dev dependencies.

Nick Alexander :nalexander [he/him] has approved the revision.
Attachment #9013260 - Flags: review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ef2bffa13bc
Update mozilla-central's package.json for being more generic, and move existing ESLint modules to dev dependencies. r=firefox-build-system-reviewers,nalexander
https://hg.mozilla.org/mozilla-central/rev/4ef2bffa13bc
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Regressions: 1551551
You need to log in before you can comment on or make changes to this bug.