Closed Bug 1495452 Opened 7 years ago Closed 7 years ago

Selecting Text Crashes Focus + GV

Categories

(GeckoView :: General, defect, P1)

Product:
GeckoView
Component:
General
Version:
62 Branch
Type:
defect

Tracking

(geckoview62 fixed, firefox-esr60 unaffected, firefox62 wontfix, firefox63 fixed, firefox64 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
geckoview62 --- fixed
firefox-esr60 --- unaffected
firefox62 --- wontfix
firefox63 --- fixed
firefox64 --- fixed

People

(Reporter: ekager, Assigned: jchen)

References

Details

Attachments

(1 file)

Don't crash without vibrate permission
2.46 KB, patch
jchen
: review+
pascalc
: approval-mozilla-beta+
RyanVM
: approval-mozilla-geckoview62+
Details | Diff | Splinter Review
On the latest 62 Rel Branch 62.0.3.20180928184514 selecting any text will crash Focus. See: https://github.com/mozilla-mobile/focus-android/issues/3520
Assignee: nobody → nchen
Blocks: 1494739
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f52dcc4f7290 Don't crash when there is no vibrate permission; r=me
Catch exceptions when we don't have the vibrate permission.
Attachment #9013385 - Flags: review+
Comment on attachment 9013385 [details] [diff] [review] Don't crash without vibrate permission Approval Request Comment [Feature/Bug causing the regression]: bug 1494739 [User impact if declined]: Crash when selecting text in GV apps like Focus [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: No [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Small patch that only addresses the crash [String changes made/needed]: None
Attachment #9013385 - Flags: approval-mozilla-geckoview62?
Attachment #9013385 - Flags: approval-mozilla-beta?
Comment on attachment 9013385 [details] [diff] [review] Don't crash without vibrate permission Already landed on GV62, approving for posterity.
Attachment #9013385 - Flags: approval-mozilla-geckoview62? → approval-mozilla-geckoview62+
https://hg.mozilla.org/mozilla-central/rev/f52dcc4f7290
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox64: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Comment on attachment 9013385 [details] [diff] [review] Don't crash without vibrate permission Approved for beta 12
Attachment #9013385 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Product: Firefox for Android → GeckoView
Version: Firefox 62 → 62 Branch
Keywords: crash, regression
Target Milestone: Firefox 64 → mozilla64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: