Closed Bug 1495452 Opened 1 year ago Closed 1 year ago
Selecting Text Crashes Focus + GV
On the latest 62 Rel Branch 184.108.40.20680928184514 selecting any text will crash Focus. See: https://github.com/mozilla-mobile/focus-android/issues/3520
Assignee: nobody → nchen
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/f52dcc4f7290 Don't crash when there is no vibrate permission; r=me
Catch exceptions when we don't have the vibrate permission.
Attachment #9013385 - Flags: review+
Comment on attachment 9013385 [details] [diff] [review] Don't crash without vibrate permission Approval Request Comment [Feature/Bug causing the regression]: bug 1494739 [User impact if declined]: Crash when selecting text in GV apps like Focus [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: No [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Small patch that only addresses the crash [String changes made/needed]: None
Comment on attachment 9013385 [details] [diff] [review] Don't crash without vibrate permission Already landed on GV62, approving for posterity.
Attachment #9013385 - Flags: approval-mozilla-geckoview62? → approval-mozilla-geckoview62+
Comment on attachment 9013385 [details] [diff] [review] Don't crash without vibrate permission Approved for beta 12
Attachment #9013385 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.