1495539 - mingw-clang toolchain build broken with clang trunk

Status: RESOLVED FIXED

(Firefox Build System :: General: Unsupported Platforms, enhancement, P5)

Description

[Tom Ritter [:tjr]]

Somewhere in clang trunk the build has broken... Need to bisect before we can update it...

Comment 1

[Tom Ritter [:tjr]]

Attachment: switch clang 7 to trunk

When we fix this, this patch will switch us over to trunk.

Comment 2

[(Away)]

Is it bug 1494603?

Comment 3

[Tom Ritter [:tjr]]

(In reply to David Major [:dmajor] from comment #2)
> Is it bug 1494603?

No, this is the toolchain build itself is broken, example: https://treeherder.mozilla.org/#/jobs?repo=try&revision=eddb409d8a9fe3e54a9036c695cd396a9a4d07ac

Comment 4

[Tom Ritter [:tjr]]

Attachment: switch from clang 7 to trunk

So Jacek and Martin pointed out the initial fix I needed with CLANG_VERSION

The new problem (which is in the firefox build step, not the toolchain build) is an error about stdbool.h as shown here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b381a319b033b1cf0a539f87169815b085396e3

Comment 5

[Tom Ritter [:tjr]]

Attachment: Bug 1495539 Set up MinGW-clang to track clang trunk

The part of this patch I'm unsatisfied with is in the mozconfig I hardcode the version (currently 8 for trunk.)  In the toolchain-build-script I can get the version dynamically from the compiler; but the compiler isn't downloaded yet when the mozconfig is evaluated; so I can't do the same thing here...

Comment 6

[Tom Ritter [:tjr]]

Attachment: Bug 1495539 Set up MinGW-clang to track clang trunk

Previously r+-ed I just needed to rebase because I landed a patch in between

Comment 7

[Tom Ritter [:tjr]]

Attachment: Bug 1495539 Set up MinGW-clang to track clang trunk r=ted

Carrying over r+ from ted after I rebased it

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/299734d1636d
Set up MinGW-clang to track clang trunk r=ted

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/299734d1636d

Comment 10

[Tom Prince [:tomprince]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/45bea853246f