Closed Bug 1495571 Opened Last year Closed Last year

Refactor CharacterEncodings.cpp!InflateUTF8StringToBuffer

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(8 files)

46 bytes, text/x-phabricator-request
efaust
: review+
Details | Review
46 bytes, text/x-phabricator-request
efaust
: review+
Details | Review
46 bytes, text/x-phabricator-request
efaust
: review+
Details | Review
46 bytes, text/x-phabricator-request
efaust
: review+
Details | Review
46 bytes, text/x-phabricator-request
efaust
: review+
Details | Review
46 bytes, text/x-phabricator-request
efaust
: review+
Details | Review
46 bytes, text/x-phabricator-request
efaust
: review+
Details | Review
46 bytes, text/x-phabricator-request
efaust
: review+
Details | Review
No description provided.
This is an old hack that we have not needed for ages. It's all JSContext now.
Comment on attachment 9013497 [details]
Bug 1495571 - Part 1: Do not parameterize character-encoding templates for ContextT. r?efaust

Eric Faust [:efaust] has approved the revision.
Attachment #9013497 - Flags: review+
Comment on attachment 9013501 [details]
Bug 1495571 - Part 3: Simplify InflateUTF8Action now that the error behavior has been factored out. r?efaust

Eric Faust [:efaust] has approved the revision.
Attachment #9013501 - Flags: review+
This is not great but we're getting rid of CharT.

Depends on D7374
Comment on attachment 9013502 [details]
Bug 1495571 - Part 4: Remove first template parameter to InflateUTF8StringHelper, as it is now always Count. r?efaust

Eric Faust [:efaust] has approved the revision.
Attachment #9013502 - Flags: review+
Comment on attachment 9013503 [details]
Bug 1495571 - Part 5: Rename InflateUTF8StringToBuffer and add a little documentation. r?efaust

Eric Faust [:efaust] has approved the revision.
Attachment #9013503 - Flags: review+
Comment on attachment 9013505 [details]
Bug 1495571 - Part 7: Make the output a lambda. r?efaust

Eric Faust [:efaust] has approved the revision.
Attachment #9013505 - Flags: review+
Comment on attachment 9013506 [details]
Bug 1495571 - Part 8: Add support for early escape from the loop. Eliminate the Action enum. r?efaust

Eric Faust [:efaust] has approved the revision.
Attachment #9013506 - Flags: review+
Comment on attachment 9013500 [details]
Bug 1495571 - Part 2: Introduce OnUTF8Error. r?efaust

Eric Faust [:efaust] has approved the revision.
Attachment #9013500 - Flags: review+
Comment on attachment 9013504 [details]
Bug 1495571 - Part 6: Specify the replacement character explicitly, not as a function of CharT. r?efaust

Eric Faust [:efaust] has approved the revision.
Attachment #9013504 - Flags: review+
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5a66c886df15
Part 1: Do not parameterize character-encoding templates for ContextT. r=efaust
https://hg.mozilla.org/integration/autoland/rev/477574223818
Part 2: Introduce OnUTF8Error. r=efaust
https://hg.mozilla.org/integration/autoland/rev/0f95c1e8fca9
Part 3: Simplify InflateUTF8Action now that the error behavior has been factored out. r=efaust
https://hg.mozilla.org/integration/autoland/rev/efc1efbc569a
Part 4: Remove first template parameter to InflateUTF8StringHelper, as it is now always Count. r=efaust
https://hg.mozilla.org/integration/autoland/rev/a35af6689749
Part 5: Rename InflateUTF8StringToBuffer and add a little documentation. r=efaust
https://hg.mozilla.org/integration/autoland/rev/a82ed21f664c
Part 6: Specify the replacement character explicitly, not as a function of CharT. r=efaust
https://hg.mozilla.org/integration/autoland/rev/b999f2758e3e
Part 7: Make the output a lambda. r=efaust
https://hg.mozilla.org/integration/autoland/rev/995cd5fca351
Part 8: Add support for early escape from the loop. Eliminate the Action enum. r=efaust
Assignee: nobody → jorendorff
You need to log in before you can comment on or make changes to this bug.