Closed Bug 1495611 Opened Last year Closed Last year

Add more testcases for BinAST

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox64 --- disabled
firefox65 --- disabled
firefox66 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Depends on 4 open bugs, Blocks 1 open bug)

Details

Attachments

(4 files)

currently we have some test files for BinAST, converted from jstests.
we should add more cases, to make sure we cover full feature of the target language version.

the plan is to use babel to transpile our test case into specific version, and encode it as binjs file, and add it.

it needs the auto-regeneration script (bug 1491104) in order to update them after adding JS testcase, or bumping file format version.
Depends on: 1496329
Depends on: 1496330
Depends on: 1496331
Depends on: 1496332
Depends on: 1496333
Depends on: 1496334
Depends on: 1496335
Priority: -- → P3
Depends on: 1497777
Depends on: 1497781
Depends on: 1497784
Depends on: 1497788
Depends on: 1497791
Depends on: 1497792
Depends on: 1497796
Blocks: 1349917
Depends on: 1498488
Depends on: 1499998
Depends on: 1499999
Depends on: 1500836
Depends on: 1501155
Depends on: 1501537
Depends on: 1501541
Depends on: 1520353

WIP: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bee0f62cb121cf939a98439c99a154d56ba3f041&selectedJob=222365144

I don't observe notable increase of the time taken by running SM jobs.

                   | m-c      | m-c      | m-c      | m-c      | patched
                   | 347b8151 | e3cb5a5e | 1312db5d | 6e8f0fdb |
                   | [min]    | [min]    | [min]    | [min]    | [min]
-------------------+----------+----------+----------+----------+-----------
Linux debug        |          |          |          |          |
  SM(arm)          | 36       | 43       | 43       | 38       | 50
-------------------+----------+----------+----------+----------+-----------
Linux x64 debug    |          |          |          |          |
  SM(arm64)        | 32       | 23       | 23       | 30       | 25
  SM(cgc)          | 45       | 36       | 50       | 39       | 50
  SM(p)            | 45       | 56       | 47       | 55       | 49
  SM(r)            | 57       | 54       | 47       | 45       | 50
-------------------+----------+----------+----------+----------+-----------
Linux x64 opt      |          |          |          |          |
  SM(asan)         | 28       | 27       | 23       | 20       | 27
  SM(f)            | 25       | 22       | 19       | 17       | 18
  SM(nojit)        | 15       | 20       | 18       | 22       | 19
  SM(p)            | 44       | 37       | 50       | 41       | 42
  SM(pkg)          | 44       | 61       | 39       | 44       | 37
  SM(tsan)         | 53       | 48       | 63       | 58       | 55

windows SM jobs are taking longer.

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=f8eea703d32591ac403d82285602a4d1037f138f

I think we should skip them on windows.
will prepare patch tomorrow.

Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/da5caa27480c
Part 1: Add script to encode jit-tests into BinAST files. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/0baeacb1800b
Part 2: Apply cgc-jittest-timeouts.txt to binast directory. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/a5e61a18508d
Part 3: Add jit-tests in BinAST format. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/69d19e1214f7
Part 4: Do not run binast/lazy and binast/nonlazy on windows. r=Yoric

looks like binary files are corrupted while submitting or landing.
will land them to m-i.

Flags: needinfo?(arai.unmht)

apparently we need to skip running binast tests also on android and osx.
will post another patch

Attachment #9037464 - Attachment description: Bug 1495611 - Part 4: Do not run binast/lazy and binast/nonlazy on windows. r?Yoric → Bug 1495611 - Part 4: Run binast/lazy and binast/nonlazy only on linux64 SM(p,cgc). r?sfink
https://hg.mozilla.org/integration/mozilla-inbound/rev/e894908efca6cb9589b66057f00057ebea81fed5
Bug 1495611 - Part 1: Add script to encode jit-tests into BinAST files. r=Yoric

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7fb651a0941eb392750a40cf5a1f51e253ee0f5
Bug 1495611 - Part 2: Apply cgc-jittest-timeouts.txt to binast directory. r=Yoric

https://hg.mozilla.org/integration/mozilla-inbound/rev/17e87458d7ec374800c3283a2af085234c9e1816
Bug 1495611 - Part 3: Add jit-tests in BinAST format. r=Yoric

https://hg.mozilla.org/integration/mozilla-inbound/rev/c60e6c0c2e2318295d1bec96e95ec7eaa9b48087
Bug 1495611 - Part 4: Run binast/lazy and binast/nonlazy only on linux64 SM(p,cgc). r=Yoric,sfink
Depends on: 1543375
You need to log in before you can comment on or make changes to this bug.