1495612 - Add custom search keywords for DoH

Status: VERIFIED FIXED

(Firefox :: Settings UI, enhancement, P1)

Description

[Erica Wright [:ewright]]

Allow users to find the Connection Settings panel in about:preferences when searching for "doh" or "trr".

Add hidden searchable keywords to this panel.

Comment 1

[Erica Wright [:ewright]]

Attachment: Bug 1495612 - Add custom search keywords for DoH. r?flod,sfoster

On about:preferences, if a user enters "doh" or "trr" in the search, it brings them to the Connection Settings panel.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/648984f7f9cc
Add custom search keywords for DoH. r=jaws

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/648984f7f9cc

Comment 4

[Mohammad Maruf Rahman]

This bug was about adding custom search keywords for DoH and I have seen the feature being implemented with latest Nightly!

Build ID 	20181007100131
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

Comment 5

[Erica Wright [:ewright]]

Comment on attachment 9013471 [details]
Bug 1495612 - Add custom search keywords for DoH. r?flod,sfoster

Request for beta 63 uplift

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1495612

User impact if declined: Users will not be able to find the "dns over https" preferences screen by searching for "dns" nor "trr"

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: Yes

If yes, steps to reproduce: - go to 'about:preferences', 
- in the search bar enter "trr" (or "doh")
- you should see "Network Settings" under the search results, and a little yellow flag pointing to the settings button.
note: it is expected that there will not be any highlighted text

List of other uplifts needed: NA

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This adds extra search keywords, a very minor change. No useability differences if the user does not use those keywords.

String changes made/needed: none

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9013471 [details]
Bug 1495612 - Add custom search keywords for DoH. r?flod,sfoster

Trivial patch verified on nightly, approved for uplift to our last 63 beta. Thanks.

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6fc845dd67de

Comment 8

[Gyula Palko[:gpalko]]

Verified on Nightly 64(20181009183338), that in about:preferences "Network Settings" is returned when searching for "doh" or "trr".

Comment 9

[Gyula Palko[:gpalko]]

Verified on Beta 63b14(20181011200118), that in about:preferences "Network Settings" is returned when searching for "doh" or "trr".