1495641 - Don't mix clang and clang-tidy files

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

As seen when landing bug 1492663, clang-tidy and clang toolchains extract to the same directory, with the former overwriting the files from the latter, and that causes problems.

Both toolchains should be separated.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1495641 - Make clang-tidy toolchains use a clang-tidy/ directory instead of clang/

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ff4a396300c
Make clang-tidy toolchains use a clang-tidy/ directory instead of clang/. r=ted

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae4e4c068139
Backout changeset 3ff4a396300c to give time to toolchains to build without blocking other landings.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d090265a5a85
Make clang-tidy toolchains use a clang-tidy/ directory instead of clang/. r=ted

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d090265a5a85

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Indeed and sorry about that but it would have been nice to be informed as this change broke some tools (release services)

Comment 7

[Mike Hommey [:glandium]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #6)
> Indeed and sorry about that but it would have been nice to be informed as
> this change broke some tools (release services)

I was assuming that out-of-tree uses of clang-tidy were ensured to be working through `mach static-analysis autotest`, aka the static-analysis-autotest tasks. If that's not the case, then there should be such a job. It's already a problem that `mach static-analysis autotest` does not share code with `mach static-analysis`. I was careful enough to check all the in-tree code that uses clang-tidy and changed both, but if I had acted purely in reaction to the static-analysis-autotest tasks failure I originally had, I'd have made them work and `mach static-analysis` would have been broken.