Closed Bug 1495641 Opened Last year Closed Last year
Don't mix clang and clang-tidy files
46 bytes, text/x-phabricator-request
|Details | Review|
As seen when landing bug 1492663, clang-tidy and clang toolchains extract to the same directory, with the former overwriting the files from the latter, and that causes problems. Both toolchains should be separated.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3ff4a396300c Make clang-tidy toolchains use a clang-tidy/ directory instead of clang/. r=ted
Backout by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/ae4e4c068139 Backout changeset 3ff4a396300c to give time to toolchains to build without blocking other landings.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d090265a5a85 Make clang-tidy toolchains use a clang-tidy/ directory instead of clang/. r=ted
Indeed and sorry about that but it would have been nice to be informed as this change broke some tools (release services)
(In reply to Sylvestre Ledru [:sylvestre] from comment #6) > Indeed and sorry about that but it would have been nice to be informed as > this change broke some tools (release services) I was assuming that out-of-tree uses of clang-tidy were ensured to be working through `mach static-analysis autotest`, aka the static-analysis-autotest tasks. If that's not the case, then there should be such a job. It's already a problem that `mach static-analysis autotest` does not share code with `mach static-analysis`. I was careful enough to check all the in-tree code that uses clang-tidy and changed both, but if I had acted purely in reaction to the static-analysis-autotest tasks failure I originally had, I'd have made them work and `mach static-analysis` would have been broken.
You need to log in before you can comment on or make changes to this bug.