Inspector has dark input fields on Linux with light theme and a dark GTK theme

RESOLVED FIXED in Firefox 64

Status

enhancement
P3
normal
RESOLVED FIXED
11 months ago
10 months ago

People

(Reporter: fvsch, Assigned: fvsch)

Tracking

Trunk
Firefox 64
All
Linux
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(3 attachments)

Using the "Adwaita Dark" GTK theme (the main dark theme offered in Gnome 3), we end up with dark styles for <select>, <input type="checkbox">, scrollbars, and text inputs.

Forcibly switching GTK themes is probably too difficult. Firefox does things like that already, with unwanted impact on web content:
https://bugzilla.mozilla.org/show_bug.cgi?id=1283086

For devtools we could leave the scrollbars and checkboxes as-is, but least fix the search input style.

It seems that for search text inputs we already have `-moz-appearance: none` and a few styles like `border: solid 1px` which resets GTK styles, but we still end up with a dark background. We could fix that by explicitly declaring a `background-color`.
The dark-theme.css does it, but not the light-theme.css.

The filter inputs in Console and Network are not affected.
Scrollbar colors is related to Bug 1460109 (not sure it'll add the capability to style Linux/GTK scrollbars though).
Also affected: new RDM.
Posted image rdm-dark-inputs.png
Priority: -- → P3
Assignee: nobody → florens
Status: NEW → ASSIGNED
Summary: Dark GTK widgets clash with the DevTools light theme → Inspector has dark input fields on Linux with light theme and a dark GTK theme
I'd like to restrict the scope of this bug to just the Inspector's filter/search inputs, and other users of devtools-textinput (and related classes), to make it more manageable. I have a fix for that which I'd like to land if possible. I can open follow-up bugs for the RDM and other places that need more work.
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd606d8bb763
Declare devtools-textinput colors explicitly; r=pbro
https://hg.mozilla.org/mozilla-central/rev/cd606d8bb763
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.