1495693 - Inspector has dark input fields on Linux with light theme and a dark GTK theme

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Florens Verschelde :fvsch]

Attachment: inspector-linux-dark-inputs.png

Using the "Adwaita Dark" GTK theme (the main dark theme offered in Gnome 3), we end up with dark styles for <select>, <input type="checkbox">, scrollbars, and text inputs.

Forcibly switching GTK themes is probably too difficult. Firefox does things like that already, with unwanted impact on web content:
https://bugzilla.mozilla.org/show_bug.cgi?id=1283086

For devtools we could leave the scrollbars and checkboxes as-is, but least fix the search input style.

It seems that for search text inputs we already have `-moz-appearance: none` and a few styles like `border: solid 1px` which resets GTK styles, but we still end up with a dark background. We could fix that by explicitly declaring a `background-color`.
The dark-theme.css does it, but not the light-theme.css.

The filter inputs in Console and Network are not affected.

Comment 1

[Florens Verschelde :fvsch]

Scrollbar colors is related to Bug 1460109 (not sure it'll add the capability to style Linux/GTK scrollbars though).

Comment 2

[Florens Verschelde :fvsch]

Also affected: new RDM.

Comment 3

[Florens Verschelde :fvsch]

Attachment: rdm-dark-inputs.png

Comment 4

[Florens Verschelde :fvsch]

For scrollbars: https://bugzilla.mozilla.org/show_bug.cgi?id=1471163

Comment 5

[Florens Verschelde :fvsch]

I'd like to restrict the scope of this bug to just the Inspector's filter/search inputs, and other users of devtools-textinput (and related classes), to make it more manageable. I have a fix for that which I'd like to land if possible. I can open follow-up bugs for the RDM and other places that need more work.

Comment 6

[Florens Verschelde :fvsch]

Attachment: Bug 1495693 - Declare devtools-textinput colors explicitly; r?pbro

Comment 7

[Florens Verschelde :fvsch]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd07e029b918d063dd357be97fa83cee2398b0a7

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd606d8bb763
Declare devtools-textinput colors explicitly; r=pbro

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/cd606d8bb763