Provide user friendly information about a flex item's sizing

RESOLVED FIXED in Firefox 64

Status

enhancement
P2
normal
RESOLVED FIXED
7 months ago
6 months ago

People

(Reporter: pbro, Assigned: pbro)

Tracking

(Blocks 2 bugs)

unspecified
Firefox 64
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

7 months ago
In bug 1478397, we will land the very first version of the flex item sizing sidebar.
For now, it will contain a flat list of properties that relate to where a flex item got its size.

Now, in this second bug, we will transform this list into something that contains more information, and more user-friendly information. The goal being to explain in a straightforward way how an item really got its size.
(Assignee)

Updated

7 months ago
Blocks: 1478396
Severity: normal → enhancement
Priority: -- → P2
(Assignee)

Updated

7 months ago
See Also: → 1496439
(Assignee)

Updated

7 months ago
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
QA Contact: gl
(Assignee)

Comment 1

7 months ago
Posted patch sizing.diffSplinter Review
WIP patch just to show the progress made so far.
I need to wait for the blocker bug to land first and then I'll rebase this.
I still need to polish this patch up and write tests.
(Assignee)

Updated

7 months ago
Blocks: 1496740
Assignee: pbrosset → nobody
Status: ASSIGNED → NEW
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
(Assignee)

Updated

7 months ago
Blocks: 1497152
(Assignee)

Updated

7 months ago
Blocks: 1488885
(Assignee)

Comment 2

7 months ago
Still a lot of work to do here, but I'd like to try to land this in 64 anyway. It's not a big deal because we plan on keeping the feature hidden behind a flag for now.
The reason is that there is some actor code that landed in 64 with bug 1478397, and I'm changing it in this bug. So I'd rather have those changes in 64 too and avoid messy backwards compat code.
So I'll polish up this patch and fix the obvious issues, but won't wait until it's 100% robust before landing. We'll do this through follow-upo bugs and will only turn the flag ON when things are stable anyway.
(Assignee)

Comment 3

7 months ago
MozReview-Commit-ID: 3cSeShKP6TE
(Assignee)

Comment 4

7 months ago
MozReview-Commit-ID: 3cSeShKP6TE
Attachment #9015900 - Attachment is obsolete: true
Blocks: dt-flexbox

Comment 5

7 months ago
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f5483bd51ed
More user-friendly Flex item sizing information; r=gl

Comment 6

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6f5483bd51ed
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.