Closed Bug 1495812 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 13318 - Align more closely with Gecko for clip-path reference box.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 13318 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13318
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:
>  Align more closely with Gecko for clip-path reference box.
>  
>  This changes how we calculate the reference box when the layout box is a
>  non-atomic inline.
>  
>  It was very broken for LayoutNG; we just set the height to 0. For legacy
>  layout we used the width of the bounding box for all lines and the
>  height of the first fragment.
>  
>  Instead, consistently use the size of the first fragment, in both NG and
>  legacy. Also get it right if writing-mode is vertical-rl.
>  
>  Bug: 641907
>  Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
>  Change-Id: I652f197bc3d950fad1bf6067dc5f38c2df72a0a3
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1256808
>  WPT-Export-Revision: be1251726295a9465a0aa71125c3f9ee70cc6c61
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 3 tests
PASS   : 2
FAIL   : 1

New tests that have failures or other problems:
/css/css-masking/clip-path/clip-path-inline-002.html: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c32e7534637
[wpt PR 13318] - Align more closely with Gecko for clip-path reference box., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b573a0ec2a1
[wpt PR 13318] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/1c32e7534637
https://hg.mozilla.org/mozilla-central/rev/3b573a0ec2a1
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.