Closed
Bug 1495964
Opened 6 years ago
Closed 6 years ago
Remove unnecessary NS_ASSERTION in nsChildView::DispatchEvent()
Categories
(Core :: Widget: Cocoa, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Keywords: inputmethod)
Attachments
(1 file)
nsChildView::DispatchEvent() checks whether keyboard event is being dispatched during composition. https://searchfox.org/mozilla-central/rev/6ddb5fb144993fb5de044e2e8d900d7643b98a4d/widget/cocoa/nsChildView.mm#1481-1483 This was reasonable check before fixing bug 1446401. However, this is valid situation in UI Events spec. So, we should remove this NS_ASSERTION.
|
Assignee | |
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc9305081223a5b020da53b4d718f29380a4f779
|
|
Assignee | |
Comment 2•6 years ago
|
||
The assertion was reasonable check before fixing bug 1446401. However, this is currently valid situation in UI Events spec.
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/323691f11567 Remove unnecessary NS_ASSERTION in nsChildView::DispatchEvent() r=m_kato
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/323691f11567
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•