1495994 - merge ImageValue, URLValue, and URLValueData

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Cameron McCormack (:heycam)]

The split between these types is a needless complication after bug 1495645.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Bug 1495994 - Part 4: Merge ImageValue, URLValue, and URLValue (and corresponding types on the Rust side)

All things named "ImageValue" (member variables, arguments, etc.) are
renamed to "URLValue".

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Bug 1495994 - Part 1: Make URLValue constructor take CORSMode argument

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Bug 1495994 - Part 2: Remove some constructors/methods

Depends on D7593

Comment 4

[Cameron McCormack (:heycam)]

Attachment: Bug 1495994 - Part 3: Move mLoadID up from ImageValue to URLValueData

Depends on D7594

Comment 5

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f2b993bf4b20c71d151162d9858078e260d7e0d&group_state=expanded

Will probably need to rebase over the nsCSSValue simplifications but shouldn't be much.

Comment 6

[Cameron McCormack (:heycam)]

Attachment: Bug 1495994 - Part 4: Merge css::{URLValueData, ImageValue} into css::URLValue

Depends on D7595

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6de39c7149c
Part 1: Make URLValue constructor take CORSMode argument r=emilio
https://hg.mozilla.org/integration/autoland/rev/68ce4cece28c
Part 2: Remove some constructors/methods r=emilio
https://hg.mozilla.org/integration/autoland/rev/48b5f15672ab
Part 3: Move mLoadID up from ImageValue to URLValueData r=emilio
https://hg.mozilla.org/integration/autoland/rev/f6e5bc9af12f
Part 4: Merge css::{URLValueData, ImageValue} into css::URLValue r=emilio

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/a6de39c7149c
https://hg.mozilla.org/mozilla-central/rev/68ce4cece28c
https://hg.mozilla.org/mozilla-central/rev/48b5f15672ab
https://hg.mozilla.org/mozilla-central/rev/f6e5bc9af12f