Closed Bug 1495994 Opened 2 years ago Closed 2 years ago

merge ImageValue, URLValue, and URLValueData

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(4 files, 1 obsolete file)

The split between these types is a needless complication after bug 1495645.
All things named "ImageValue" (member variables, arguments, etc.) are
renamed to "URLValue".
Attachment #9013986 - Attachment is obsolete: true
Attachment #9013986 - Attachment is obsolete: false
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f2b993bf4b20c71d151162d9858078e260d7e0d&group_state=expanded

Will probably need to rebase over the nsCSSValue simplifications but shouldn't be much.
Attachment #9013986 - Attachment is obsolete: true
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a6de39c7149c
Part 1: Make URLValue constructor take CORSMode argument r=emilio
https://hg.mozilla.org/integration/autoland/rev/68ce4cece28c
Part 2: Remove some constructors/methods r=emilio
https://hg.mozilla.org/integration/autoland/rev/48b5f15672ab
Part 3: Move mLoadID up from ImageValue to URLValueData r=emilio
https://hg.mozilla.org/integration/autoland/rev/f6e5bc9af12f
Part 4: Merge css::{URLValueData, ImageValue} into css::URLValue r=emilio
You need to log in before you can comment on or make changes to this bug.