merge ImageValue, URLValue, and URLValueData

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P3
normal
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

unspecified
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(4 attachments, 1 obsolete attachment)

Assignee

Description

8 months ago
The split between these types is a needless complication after bug 1495645.
Assignee

Comment 1

8 months ago
All things named "ImageValue" (member variables, arguments, etc.) are
renamed to "URLValue".
Attachment #9013986 - Attachment is obsolete: true
Attachment #9013986 - Attachment is obsolete: false
Assignee

Comment 5

8 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f2b993bf4b20c71d151162d9858078e260d7e0d&group_state=expanded

Will probably need to rebase over the nsCSSValue simplifications but shouldn't be much.
Attachment #9013986 - Attachment is obsolete: true

Comment 7

8 months ago
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a6de39c7149c
Part 1: Make URLValue constructor take CORSMode argument r=emilio
https://hg.mozilla.org/integration/autoland/rev/68ce4cece28c
Part 2: Remove some constructors/methods r=emilio
https://hg.mozilla.org/integration/autoland/rev/48b5f15672ab
Part 3: Move mLoadID up from ImageValue to URLValueData r=emilio
https://hg.mozilla.org/integration/autoland/rev/f6e5bc9af12f
Part 4: Merge css::{URLValueData, ImageValue} into css::URLValue r=emilio
You need to log in before you can comment on or make changes to this bug.