merge ImageValue, URLValue, and URLValueData

RESOLVED FIXED in Firefox 64

Status

()

P3
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

unspecified
mozilla64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Assignee)

Description

5 months ago
The split between these types is a needless complication after bug 1495645.
(Assignee)

Comment 1

5 months ago
Created attachment 9013986 [details]
Bug 1495994 - Part 4: Merge ImageValue, URLValue, and URLValue (and corresponding types on the Rust side)

All things named "ImageValue" (member variables, arguments, etc.) are
renamed to "URLValue".
(Assignee)

Comment 2

5 months ago
Created attachment 9013987 [details]
Bug 1495994 - Part 1: Make URLValue constructor take CORSMode argument
(Assignee)

Comment 3

5 months ago
Created attachment 9013988 [details]
Bug 1495994 - Part 2: Remove some constructors/methods

Depends on D7593
(Assignee)

Comment 4

5 months ago
Created attachment 9013989 [details]
Bug 1495994 - Part 3: Move mLoadID up from ImageValue to URLValueData

Depends on D7594
Attachment #9013986 - Attachment is obsolete: true
Attachment #9013986 - Attachment is obsolete: false
(Assignee)

Comment 5

4 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f2b993bf4b20c71d151162d9858078e260d7e0d&group_state=expanded

Will probably need to rebase over the nsCSSValue simplifications but shouldn't be much.
(Assignee)

Comment 6

4 months ago
Created attachment 9015441 [details]
Bug 1495994 - Part 4: Merge css::{URLValueData, ImageValue} into css::URLValue

Depends on D7595
Attachment #9013986 - Attachment is obsolete: true

Comment 7

4 months ago
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a6de39c7149c
Part 1: Make URLValue constructor take CORSMode argument r=emilio
https://hg.mozilla.org/integration/autoland/rev/68ce4cece28c
Part 2: Remove some constructors/methods r=emilio
https://hg.mozilla.org/integration/autoland/rev/48b5f15672ab
Part 3: Move mLoadID up from ImageValue to URLValueData r=emilio
https://hg.mozilla.org/integration/autoland/rev/f6e5bc9af12f
Part 4: Merge css::{URLValueData, ImageValue} into css::URLValue r=emilio

Comment 8

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a6de39c7149c
https://hg.mozilla.org/mozilla-central/rev/68ce4cece28c
https://hg.mozilla.org/mozilla-central/rev/48b5f15672ab
https://hg.mozilla.org/mozilla-central/rev/f6e5bc9af12f
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.