1496009 - missing link to some attachments in email notification

Status: RESOLVED DUPLICATE of bug 1478271

(bugzilla.mozilla.org :: Email Notifications, defect)

Description

[Julien Cristau [:jcristau]]

Recently(?) it seems some emails are missing the link to the created attachment.

E.g. for bug 1488439 comment 12 the email contains:

          <pre class=3D"comment" style=3D"font-size: initial">Created attac=
hment 9013804


The sandbox blocks GetTempFileName's prior response, causing the system to =
end
up searching a number of (inaccessible) folders to use as a replacement for=
 the
temp folder.  This patch provides a path to a new folder on the command lin=
e
for the plugin process.  This new temp folder, specific to this plugin proc=
ess
instance, is then communicated to the system via the TEMP/TMP environment
variables.  This is similar to what is done for the content process but avo=
ids
nsDirectoryService, which doesn't exist in plugin processes.</pre>

And for the very next comment in the same bug:

          <pre class=3D"comment" style=3D"font-size: initial">Created <span=
 class=3D""><a href=3D"https://bugzilla.mozilla.org/attachment.cgi?id=3D901=
3805" name=3D"attach_9013805" title=3D"Bug 1488439: Part 2 - Patch GetFileA=
ttributesW for appdata parent folders in sandboxed plugin process (r?bobowe=
n)">attachment 9013805 [details]</a> <a href=3D"https://bugzilla.mozilla.org/attachme=
nt.cgi?id=3D9013805&amp;action=3Dedit" title=3D"Bug 1488439: Part 2 - Patch=
 GetFileAttributesW for appdata parent folders in sandboxed plugin process =
(r?bobowen)">[details]</a></span>
<a class=3D"bz_bug_link
          bz_status_NEW"
   title=3D"NEW - Comcast video won't play (plugin sandbox level 3 issue)"
   href=3D"show_bug.cgi?id=3D1488439">Bug 1488439</a>: Part 2 - Patch GetFi=
leAttributesW for appdata parent folders in
sandboxed plugin process (r?bobowen)

Flash analyzes the parents of the path to its appdata folder on Windows usi=
ng
GetFileAttributesW.  If it runs into an error, it makes some internal decis=
ions
that cause it to break DRM video.  Our new sandbox hardening causes
GetFileAttributesW to return an error for some components of the path.  Thi=
s
patch alters the behavior of GetFileAttributesW so that it always reports
FILE_ATTRIBUTE_DIRECTORY for any path that both 1) would otherwise return a=
n
error and 2) is an ancestor of the appdata folder.  This may not always be =
100%
accurate (for instance, if the folder is a reparse point) but restores vide=
o
functionality.

Depends on D7532</pre>