1496025 - Remove promises actor

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

Promises actor:
  https://searchfox.org/mozilla-central/source/devtools/server/actors/promises.js
has been landed as part of :gl's internship in an attempt to provide a panel displaying all page's promises with their status.
But so far, this actor has never been used in any production code.
This introduce some maintenance where we have to keep this code up to date regarding platform and devtools changes.

After rising this topic during last Devtools meeting, I got an overall approval to remove this code.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1496025 - Remove Promises actor

MozReview-Commit-ID: 55Y9FrpXCL1

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1496025 - Remove unused methods on ObjectClient related to promises

MozReview-Commit-ID: BPsMPaLz8AM

Depends on D7689

Comment 3

[Alexandre Poirot [:ochameau]]

I ended up also removing tests from the debugger, which were testing both PromisesFront and a couple of API on WebConsoleActor specific to promises:
  devtools/client/debugger/test/mochitest/browser_dbg_promises-*.js

But same as PromisesActor, these methods weren't used in the product:
  https://searchfox.org/mozilla-central/source/devtools/server/actors/object.js#727-860
Nicolas is away this week and the following, so asking for feedback about these APIs to Honza.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9a6fdac66bb
Remove Promises actor r=gl
https://hg.mozilla.org/integration/autoland/rev/1292fd4850a7
Remove unused methods on ObjectClient related to promises r=Honza,gl

Comment 5

[Andreea Pavel [:apavel]]

Backed out for failing android at org.mozilla.geckoview.test.AccessibilityTest.testMoveByCharacter

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed,busted,exception&classifiedState=unclassified&group_state=expanded&selectedJob=204024116&revision=1292fd4850a754a543f04b3b5f399f2b73597d23

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=204024116&repo=autoland&lineNumber=1401

Backout: https://hg.mozilla.org/integration/autoland/rev/632c0d2d8c2459422a8c2d8743b4f925da0596ef

Comment 6

[Alexandre Poirot [:ochameau]]

Arf... Promises actor is being used by android test framework introduced in bug 1461746.

Comment 7

[Alexandre Poirot [:ochameau]]

The Promises actor is being used from here:
  https://searchfox.org/mozilla-central/source/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/rule/GeckoSessionTestRule.java#2059-2071

We might be able to refactor this by using Reps or the API removed in the second changeset:
  https://bugzilla.mozilla.org/attachment.cgi?id=9014284
As tagging objects like that are pure hack and sounds like something that should be done via ObjectClient.

But I don't have enough cycles to look into this.

Comment 9

[Julian Descottes [:jdescottes]]

Looks like all the dependencies on DevTools promises actor was removed with https://hg.mozilla.org/integration/autoland/rev/fa0cb607fe0d in Bug 1553515.

We should be able to retry this. I will rebase the patches.

Comment 10

[Julian Descottes [:jdescottes]]

Attachment: Bug 1496025 - Remove Promises actor

Comment 11

[Julian Descottes [:jdescottes]]

Attachment: Bug 1496025 - Remove unused methods on ObjectClient related to promises

Depends on D49636

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b838594432f8
Remove Promises actor r=ochameau
https://hg.mozilla.org/integration/autoland/rev/6acfae11770c
Remove unused methods on ObjectClient related to promises r=ochameau

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b838594432f8
https://hg.mozilla.org/mozilla-central/rev/6acfae11770c