1496055 - Remove obsolete checks and code used to modify CSS selectors

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P2)

Description

[Razvan Caliman [:rcaliman]]

Prior to the ability to modify CSS rules as authored text, there was code in place to do so via the CSSOM only. This meant that unmatched rules wouldn't be shown in the Rules view. 

After Firefox 41 new code to handle modifying selectors `modifySelector2()` has been added, but the old code, `modifySelector()`, was kept for backwards compatibility when inspecting older versions of Firefox.

This bug is for removing obsolete checks and code paths for modifying selectors used prior to Firefox 41.

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1496055 - Part 1: Remove outdated checks for StyleRuleActor.modifySelectorUnmatched; r=gl

Since Firefox 41 it has been possible to add a rule with a selector
which does not match an element. The checks of the existence of this
functionality are outdated and can be safely removed.

No supported old versions of Firefox make use of the previous 
functionality anymore.

MozReview-Commit-ID: D5ZP09Ckeqd

Comment 2

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1496055 - Part 2: Remove obsolete StyleRuleActor.modifySelector() and rename modifySelector2(); r=gl

MozReview-Commit-ID: 35VrRw33sV7

Comment 3

[Razvan Caliman [:rcaliman]]

Try https://treeherder.mozilla.org/#/jobs?repo=try&revision=a40c9026977f0b9c267f4456fb23f1d98fcd9886

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6dbab52dffb7
Part 1: Remove outdated checks for StyleRuleActor.modifySelectorUnmatched; r=gl
https://hg.mozilla.org/integration/autoland/rev/dbe7858573bd
Part 2: Remove obsolete StyleRuleActor.modifySelector() and rename modifySelector2(); r=gl

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6dbab52dffb7
https://hg.mozilla.org/mozilla-central/rev/dbe7858573bd