1496056 - When a message triggers both the phishing and remote content notifications, Alt+P behaviour is confusing

Status: REOPENED

(Thunderbird :: Mail Window Front End, defect)

Description

[Harald van Dijk]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0

Steps to reproduce:

Open e-mail with both misrepresented links and remote content.
A red bar is displayed that "This message may be a scam.", with a button "Preferences" with underlined P.
No bar is visible for the remote content.
Press Alt+P.


Actual results:

It seems like nothing happens. Actually, the Preferences button on the hidden remote content notification bar is focused but not clicked, as shown by subsequently pressing Space.


Expected results:

The Preferences button on the phishing notification bar should have activated, displaying the "Ignore warning for this message" / "Edit scam detection preferences" menu.

Comment 1

[Josiah Bruner [:jsbruner]]

Attachment: EmailToReproduce

I can reproduce this issue (using the attached email) on 60.0b11 on macOS (using Ctrl+P rather than Alt+P, however).

Comment 2

[Magnus Melin [:mkmelin]]

I think this was fixed by bug 1673958.

Comment 3

[Harald van Dijk]

(In reply to Magnus Melin [:mkmelin] from comment #2)

I think this was fixed by bug 1673958.

In the current beta, Thunderbird 86.0b2, I can not get the phishing notification to trigger for emails with links that show a different URL than what they link to, even for messages without remote content, despite having "Tell me if the message I'm reading is a suspected email scam" is enabled. A fresh profile shows the same thing. I do not know whether that is by design or not, but either way, because of that, I cannot confirm whether this is fixed.

Comment 4

[Harald van Dijk]

Attachment: Updated email to reproduce

Comment 5

[Harald van Dijk]

The reason the old email no longer triggers the phishing warning is the resolution of bug #1476428. After updating the email the same way that the fix for that bug updated tests, I can see that the fix for bug 1673958, which looks like it's part of the Thunderbird 86 betas, does not help here: still, only one notification bar is displayed, and still, Alt+P behaves as before, alternating between the two "Preferences" buttons.

Comment 6

[Magnus Melin [:mkmelin]]

But it's supposed to be just one notification bar (like it is).

Which two preferences buttons are you referring to.

If, with the window in focus, I pres Alt+P the (scam warning) preferences button gets focus, like it should. To open the menubutton, i still from there have to press enter, as expected.

Comment 7

[Harald van Dijk]

(In reply to Magnus Melin [:mkmelin] from comment #6)

But it's supposed to be just one notification bar (like it is).

Two notification bars are active, one is visible. Having only one bar active and visible would be perfectly reasonable, as it having both bars active and visible, but right now the invisible notification bar interferes with the visible notification bar.

Which two preferences buttons are you referring to.

The one on the "Thunderbird has blocked remote content" notification bar and the one on the "This message may be a scam" notification bar.

If, with the window in focus, I pres Alt+P the (scam warning) preferences button gets focus, like it should. To open the menubutton, i still from there have to press enter, as expected.

No, that is not expected: if you try it in a mail that only triggers one of the notifications, Alt+P will immediately open the menu.

Comment 8

[Magnus Melin [:mkmelin]]

(In reply to Harald van Dijk from comment #7)

(In reply to Magnus Melin [:mkmelin] from comment #6)

But it's supposed to be just one notification bar (like it is).

Two notification bars are active, one is visible. Having only one bar active and visible would be perfectly reasonable, as it having both bars active and visible, but right now the invisible notification bar interferes with the visible notification bar.

On 78 you'll have two since the patch wasn't backported. On beta/trunk there is only one (and I only see one for your test message).

No, that is not expected: if you try it in a mail that only triggers one of the notifications, Alt+P will immediately open the menu.

Well, it's an accesskey for the element. And the element is a button, that has a menu. Slightly odd element, but I do think it would be unexpected for the accesskey to do anything but focus it. It's not that we're doing anything special with it - this is how that element works for accesskeys.

Comment 9

[Harald van Dijk]

(In reply to Magnus Melin [:mkmelin] from comment #8)

On 78 you'll have two since the patch wasn't backported. On beta/trunk there is only one (and I only see one for your test message).

Only one is visible, but they are both there. Dismissing the first one by clicking the X reveals the second one, but that second one was already there, and its "Preferences" button could already be invoked using the keyboard. I had tested it in the Linux x86_64 binary version of 86.0b2.

Well, it's an accesskey for the element. And the element is a button, that has a menu. Slightly odd element, but I do think it would be unexpected for the accesskey to do anything but focus it. It's not that we're doing anything special with it - this is how that element works for accesskeys.

Try it after dismissing the first notification: you should then see that Alt+P does immediately open the menu for the second notification. It's exactly because nothing special is being done that it works that way: pressing the access key for a button, when that access key is not used for anything but the button, is equivalent to clicking the button. Even if the result of clicking the button is just to show a menu.

Comment 10

[Magnus Melin [:mkmelin]]

I see. Yes, it's one notificationbox, and when there are multiple notifications they are shown by priority. When a lower priority notification is closed the next one gets revealed.