1496079 - cannot view files due to missing READ_STORAGE_PERMISSION

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Andrei Lazar]

This is a regression from bug 1451061.

Steps to reproduce:
1) Find an .html file using any file manager
2) Open using Fennec

Expected behavior:
Fennec opens the .html file in a new tab and shows its content

Actual behavior:
Fennec opens the .html file in a new tab and shows an "access file denied" message.

Comment 1

[Andrei Lazar]

Attachment: Bug 1496079 cannot view files due to missing READ_STORAGE_PERMISSION r=JanH

Fixed the issue where the read storage permission was not requested due to a typo.

Comment 2

[Jan Henning [:JanH]]

(In reply to Andrei Lazar from comment #0)
> This is a regression from bug 1451061.

Really? As far as I can tell, this was already introduced in the original implementation in bug 1271570 (https://hg.mozilla.org/mozilla-central/rev/e6109363cd6e). Still, good find, thanks for spotting this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b019dd902c4
cannot view files due to missing READ_STORAGE_PERMISSION r=JanH

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9b019dd902c4

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 6

[Andrei Lazar]

Comment on attachment 9014030 [details]
Bug 1496079 cannot view files due to missing READ_STORAGE_PERMISSION r=JanH

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1271570

User impact if declined: cannot view files due to missing READ_STORAGE_PERMISSION

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Small change, already tested by QA in Nightly.

String changes made/needed:

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9014030 [details]
Bug 1496079 cannot view files due to missing READ_STORAGE_PERMISSION r=JanH

Fix for a 62 regression caused by a typo in a function call, on nightly for a week, approved for our last 63 beta for Android, thanks.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a3d9a2b6a7be

Comment 9

[Bogdan Surd, QA [:bsurd, NI]]

Verified in the latest Nightly (2018-10-16) and Beta (63.0b15) builds, I was able to access the HTML file without any kind of issues.

Methods used:
 - steps from Comment 0 using a file manager
 - directly by accessing the file from FF by navigating through storage