Closed
Bug 1496079
Opened 7 years ago
Closed 7 years ago
cannot view files due to missing READ_STORAGE_PERMISSION
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox62 wontfix, firefox63 verified, firefox64 verified)
VERIFIED
FIXED
Firefox 64
People
(Reporter: andrei.a.lazar, Assigned: andrei.a.lazar)
References
Details
(Keywords: regression)
Attachments
(1 file)
46 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
This is a regression from bug 1451061.
Steps to reproduce:
1) Find an .html file using any file manager
2) Open using Fennec
Expected behavior:
Fennec opens the .html file in a new tab and shows its content
Actual behavior:
Fennec opens the .html file in a new tab and shows an "access file denied" message.
Assignee | ||
Comment 1•7 years ago
|
||
Fixed the issue where the read storage permission was not requested due to a typo.
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 2•7 years ago
|
||
(In reply to Andrei Lazar from comment #0)
> This is a regression from bug 1451061.
Really? As far as I can tell, this was already introduced in the original implementation in bug 1271570 (https://hg.mozilla.org/mozilla-central/rev/e6109363cd6e). Still, good find, thanks for spotting this.
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b019dd902c4
cannot view files due to missing READ_STORAGE_PERMISSION r=JanH
Keywords: checkin-needed
Comment 4•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Comment 5•7 years ago
|
||
Please request Beta approval on this when you get a chance.
Blocks: 1271570
status-firefox62:
--- → wontfix
status-firefox63:
--- → affected
Flags: qe-verify+
Flags: needinfo?(andrei.a.lazar)
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 9014030 [details]
Bug 1496079 cannot view files due to missing READ_STORAGE_PERMISSION r=JanH
[Beta/Release Uplift Approval Request]
Feature/Bug causing the regression: Bug 1271570
User impact if declined: cannot view files due to missing READ_STORAGE_PERMISSION
Is this code covered by automated tests?: No
Has the fix been verified in Nightly?: Yes
Needs manual test from QE?: No
If yes, steps to reproduce:
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): Small change, already tested by QA in Nightly.
String changes made/needed:
Flags: needinfo?(andrei.a.lazar)
Attachment #9014030 -
Flags: approval-mozilla-beta?
Comment 7•7 years ago
|
||
Comment on attachment 9014030 [details]
Bug 1496079 cannot view files due to missing READ_STORAGE_PERMISSION r=JanH
Fix for a 62 regression caused by a typo in a function call, on nightly for a week, approved for our last 63 beta for Android, thanks.
Attachment #9014030 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 8•7 years ago
|
||
bugherder uplift |
Updated•7 years ago
|
Flags: needinfo?(ioana.chiorean)
Comment 9•7 years ago
|
||
Verified in the latest Nightly (2018-10-16) and Beta (63.0b15) builds, I was able to access the HTML file without any kind of issues.
Methods used:
- steps from Comment 0 using a file manager
- directly by accessing the file from FF by navigating through storage
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: needinfo?(ioana.chiorean)
Hardware: Unspecified → ARM
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•