Closed Bug 1496087 Opened 6 years ago Closed 6 years ago

Add zbraniecki to Mercurial hook for FTL files (Fluent)

Categories

(Developer Services :: Mercurial: hg.mozilla.org, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: flod, Assigned: sheehan)

Details

Attachments

(1 file)

Zibi is listed as zbraniecki on Phabricator, and the hook fails since it checks for gandalf
https://github.com/mozilla/version-control-tools/blob/master/hghooks/mozhghooks/check/prevent_ftl_changes.py#L15-L20
Component: General → Mercurial: hg.mozilla.org
Assignee: nobody → sheehan
Status: NEW → ASSIGNED
Zibi's MozReview username was "gandalf", but he switched to
"zbraniecki" when registering for Phabricator. The hook will
fail despite his r+ review due to looking for the old username.
This commit updates the username to reflect the change.
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/2947d7ab1a4c
hghooks: update Zibi Braniecki's reviewer token to Phabricator username r=gps
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
This is now deployed.
Connor - is there a chance that something went wrong with this patch? I tried to land a patch in bug 1488973 where I'm the author (which should be enough), and it got rejected with:

"""

On Tue, October 23, 2018, 1:51 PM PDT, by zbraniecki@mozilla.com.
Revisions: D7961 diff 27471 ← D7962 diff 27472 ← D8138 diff 27473
Details: hg error in cmd: hg push -r tip upstream: pushing to ssh://hg.mozilla.org/integration/autoland searching for changes remote: adding changesets remote: adding manifests remote: adding file changes remote: added 3 changesets with 13 changes to 12 files remote: remote: ************************ ERROR ************************* remote: You are trying to commit a change to an FTL file. remote: At the moment modifying FTL files requires a review from remote: one of the L10n Drivers. remote: Please, request review from either: remote: - Francesco Lodolo (:flod) remote: - Zibi Braniecki (:zbraniecki) remote: - Axel Hecht (:pike) remote: - Stas Malolepszy (:stas) remote: ******************************************************** remote: remote: transaction abort! remote: rollback completed remote: pretxnchangegroup.mozhooks hook failed abort: push failed on remote 
"""

Since I'm the author of the patch, I believe no additional reviewer from the drivers should be required to land it.
Flags: needinfo?(sheehan)
It appears the hook currently only accepts changes where "r=" comes from one of the four FTL drivers - there is no exception for cases where a driver has authored a patch but someone else has given the r+ stamp. This line (https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hghooks/mozhghooks/check/prevent_ftl_changes.py#l69) shows that one of the nicks found in the `requal` list must be present in the `reviewers` list. Adding the behaviour you described is definitely possible, but might be a little tricky as the commit author field is unrelated to Phabricator usernames.
Flags: needinfo?(sheehan)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: