1496091 - The usage of 'Selected' in the tab context menu is inconsistent

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: 2018-10-03_1027.png

See attached screenshot.

We use 'Selected' for 'Reload Selected Tabs' and 'Close Selected Tabs', but all other multiselect-friendly menuitems don't use 'Selected' ('Mute Tabs', 'Pin Tabs', Move Tabs'). The context menu is already context-specific, meaning that the actions would only apply to the selected tabs if one of the tabs in the selection is right-clicked on.

We should remove 'Selected' from the tab context menu entries. We should keep 'Selected' in the toolbar context menu entry for 'Bookmark Selected Tabs...' since in that context it would otherwise not be clear which tabs would get bookmarked.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

I'd also like to reverse an inconsistency that I introduced via https://phabricator.services.mozilla.com/D7225. If all tabs are selected in a window, we should disable instead of hide the 'Close Tab Options' item, matching the behavior we have for the 'Move Tabs' item.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1496091 - Remove 'Selected' from a couple tab context menuitems for consistency and disable instead of hide the 'Close Tab Options' item for consistency. r?Felipe

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b907c5ebc96d
Remove 'Selected' from a couple tab context menuitems for consistency and disable instead of hide the 'Close Tab Options' item for consistency. r=Felipe

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b907c5ebc96d

Comment 5

[Cristian Fogel [:cfogel]]

Verified with 64.0b8 on Win 10, macOS0.13, Ubuntu 16.04.