The usage of 'Selected' in the tab context menu is inconsistent

VERIFIED FIXED in Firefox 64

Status

()

defect
P1
normal
VERIFIED FIXED
11 months ago
9 months ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

(Blocks 1 bug)

Trunk
Firefox 64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 verified)

Details

Attachments

(2 attachments)

Posted image 2018-10-03_1027.png
See attached screenshot.

We use 'Selected' for 'Reload Selected Tabs' and 'Close Selected Tabs', but all other multiselect-friendly menuitems don't use 'Selected' ('Mute Tabs', 'Pin Tabs', Move Tabs'). The context menu is already context-specific, meaning that the actions would only apply to the selected tabs if one of the tabs in the selection is right-clicked on.

We should remove 'Selected' from the tab context menu entries. We should keep 'Selected' in the toolbar context menu entry for 'Bookmark Selected Tabs...' since in that context it would otherwise not be clear which tabs would get bookmarked.
I'd also like to reverse an inconsistency that I introduced via https://phabricator.services.mozilla.com/D7225. If all tabs are selected in a window, we should disable instead of hide the 'Close Tab Options' item, matching the behavior we have for the 'Move Tabs' item.
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b907c5ebc96d
Remove 'Selected' from a couple tab context menuitems for consistency and disable instead of hide the 'Close Tab Options' item for consistency. r=Felipe
https://hg.mozilla.org/mozilla-central/rev/b907c5ebc96d
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Verified with 64.0b8 on Win 10, macOS0.13, Ubuntu 16.04.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.