1496161 - Add installTelemetryInfo to the WebExtensions converted themes installed from the LightweightThemeManager

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

In Bug 1430276 we added the needed changes on the Firefox side to allow LWT themes to be updated with a WebExtensions static theme (that is the converted version of the LWT theme).

The call to the AddonManager.getInstallForURL originated from LightweightThemeManager.jsm doesn't have yet the telemetryInfo parameter that we added in Bug 1433335 and so the installation coming from there are being recorded without an "installation source":

https://searchfox.org/mozilla-central/rev/a11c128b90ea85d7bb68f00c5de52c0794e0b215/toolkit/mozapps/extensions/LightweightThemeManager.jsm#296-297

We should add the telemetryInfo parameter to this AddonManager.getInstallForURL so that we can recognize this installation source in the collected telemetry events, or we should avoid to record an event for them if we are not interested to collect these installations (e.g. by using "internal" as the installation source, as we did for the installations originated from marionette and normandy).

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1496161 - Add installTelemetryInfo to converted webext themes installed from the LWTManager. r?aswan!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c0d100a4307
Add installTelemetryInfo to converted webext themes installed from the LWTManager. r=aswan

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/8c0d100a4307

Comment 4

[CosminB]

Attachment: Bug1496161.png

This issue is verified as fixed on Firefox 64.0a1(20181010235834) under Win 7 64-bit and Mac OS X 10.13.3.

Please see the attached screenshot.