1496162 - RR mochitests fail with HandleDirtyMemoryFault failed

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, defect)

Description

[Logan Smyth [:loganfsmyth]]

Attachment: rr-failure-output.txt

On OSX 10.13.6, if I run 

    ./mach test browser_dbg_rr_breakpoints-01

the test starts, but the tab crashes and then times out. I've attached the full output, but the important output seems to be

    0:04.92 TEST_START: devtools/client/debugger/new/test/mochitest/browser_dbg_rr_breakpoints-01.js
    0:05.03 GECKO(73410) MIDDLEMAN 73414 /var/folders/l_/_1tdt3wx0nj4wbprvdwcbv680000gn/T/TempRecording.73410.1
    0:05.05 INFO Waiting for event: 'RecordingFinished' on [object ParentProcessMessageManager].
    0:05.09 GECKO(73410) RECORDING 73415 /var/folders/l_/_1tdt3wx0nj4wbprvdwcbv680000gn/T/TempRecording.73410.1
    0:05.26 GECKO(73410) [Child 73414, Main Thread] WARNING: FileDescriptorSet destroyed with unconsumed descriptors: file /builds/worker/workspace/build/src/ipc/chromium/src/chrome/common/file_descriptor_set_posix.cc, line 22
    0:05.26 GECKO(73410) [Child 73414, Unnamed thread 11865d410] WARNING: FileDescriptorSet destroyed with unconsumed descriptors: file /builds/worker/workspace/build/src/ipc/chromium/src/chrome/common/file_descriptor_set_posix.cc, line 22
    0:05.26 GECKO(73410) [Child 73414, Main Thread] WARNING: FileDescriptorSet destroyed with unconsumed descriptors: file /builds/worker/workspace/build/src/ipc/chromium/src/chrome/common/file_descriptor_set_posix.cc, line 22
    0:05.28 GECKO(73410) [Child 73414, Main Thread] WARNING: FileDescriptorSet destroyed with unconsumed descriptors: file /builds/worker/workspace/build/src/ipc/chromium/src/chrome/common/file_descriptor_set_posix.cc, line 22
    0:05.28 GECKO(73410) [Child 73414, Main Thread] WARNING: FileDescriptorSet destroyed with unconsumed descriptors: file /builds/worker/workspace/build/src/ipc/chromium/src/chrome/common/file_descriptor_set_posix.cc, line 22
    0:05.59 GECKO(73410) REPLAYING 73417 /var/folders/l_/_1tdt3wx0nj4wbprvdwcbv680000gn/T/TempRecording.73410.1
    0:05.68 GECKO(73410) REPLAYING 73418 /var/folders/l_/_1tdt3wx0nj4wbprvdwcbv680000gn/T/TempRecording.73410.1
    0:05.75 GECKO(73410) [Child 73414, Unnamed thread 11865d410] WARNING: FileDescriptorSet destroyed with unconsumed descriptors: file /builds/worker/workspace/build/src/ipc/chromium/src/chrome/common/file_descriptor_set_posix.cc, line 22
    0:05.75 GECKO(73410) [Child 73414, Unnamed thread 11865d410] WARNING: FileDescriptorSet destroyed with unconsumed descriptors: file /builds/worker/workspace/build/src/ipc/chromium/src/chrome/common/file_descriptor_set_posix.cc, line 22
    0:05.91 GECKO(73410) Spew[73418]: WARNING: Repeated accesses to the same dirty address 0x0
    0:05.91 GECKO(73410) Spew[73417]: WARNING: Repeated accesses to the same dirty address 0x0
    0:06.07 GECKO(73410) ***** Fatal Record/Replay Error *****
    0:06.07 GECKO(73410) HandleDirtyMemoryFault failed 0x0 MOZ_RELEASE_ASSERT(base + size >= thread->StackBase() + thread->StackSize())

Comment 1

[Brian Hackett [Laid off!]]

Attachment: patch

This patch relaxes the checks we do when looking for a trailing inaccessible memory region after each thread's stack.  Instead of making sure there is a single allocated memory region containing the entire stack, this looks at the memory region containing the end of the stack, which should fix this assert.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/feeb9daa7d03
Relax checks when inspecting memory regions after each thread's stack, r=froydnj.

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/feeb9daa7d03