1496167 - Add installTelemetryInfo to addon installed from the ActivityStream

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

In Bug 1476713 a new "INSTALL_ADDON_FROM_URL" ASRouter action has been added to  ActivityStream, this action is used to install a suggested addon for the user when the user clicks on a related entry in the UI).

The underlying implementation is currently calling AddonManager.getInstallForURL without the additional telemetryInfo parameter that we introduced in Bug 1433335:

https://searchfox.org/mozilla-central/rev/6ddb5fb144993fb5de044e2e8d900d7643b98a4d/browser/components/newtab/lib/ASRouter.jsm#212,216

and so the installation coming from there are going to be recorded as addonsManager telemetry events without an "installation source".

We should add the telemetryInfo parameter to this AddonManager.getInstallForURL  call, so that we can recognize this source in the collected telemetry events.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4467

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/211d413f1029348fc73b39adad5f18bfed7e779e
Fix Bug 1496167 - Add installation source to addons installed from activitystream

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/4a0b6cfb51a1

Comment 4

[CosminB]

I would like to verify this bug with the STR provided in https://github.com/mozilla/activity-stream/pull/4467#issuecomment-427079517 but I am not sure how can I do the first step:  

- trigger the addon installation from ActivityStream (and allow the addon to be installed).

Kate, could you please help me with the install part?

Thanks!

Comment 5

[Andrei Oprea [:andreio]]

This is currently blocked on bug 1497261.

Comment 6

[CosminB]

Attachment: Bug1496167.png

This issue is verified as fixed on Firefox 64.0a1(20181012103207) under Win 7 64-bit and Mac OS X 10.13.3.

Please see the attached screenshot.