Closed Bug 1496220 Opened 11 months ago Closed 10 months ago

test_saveHeapSnapshot_e10s_01.html fails under TestRunnerActivity

Categories

(GeckoView :: General, enhancement, P1)

All
Android
enhancement

Tracking

(geckoview64 wontfix, firefox64 wontfix, firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
geckoview64 --- wontfix
firefox64 --- wontfix
firefox65 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

(Depends on 1 open bug)

Details

Attachments

(5 files)

No description provided.
RemoteWebNavigation is expected to pass a serialized principal, so the
default null principal should be serialized as well.
For improved security, default to a null triggering principal for
GeckoView.loadUri calls, except when loading certain privileged schemes
such as "resource" and "file".
The use of <iframe mozbrowser> in test_saveHeapSnapshot_e10s_01.html has
implicitly depended on the "network.disable.ipc.security" pref set to
false, which is the default for desktop and not applicable for Fennec.
With the new mobile test harness, this pref needs to be set explicitly
by the test.
Attachment #9014581 - Flags: review?(nfitzgerald)
Attachment #9014581 - Flags: review?(nfitzgerald)
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/abf2e04e30e4
1. Serialize default null principal in RemoteWebNavigation; r=jkt
https://hg.mozilla.org/integration/autoland/rev/daf7ced3bbcc
2. Default to null triggering principal for GeckoView.loadUri; r=esawin
https://hg.mozilla.org/integration/autoland/rev/70505741627f
3. Disable Necko IPC security for test_saveHeapSnapshot_e10s_01; r=fitzgen
Flags: needinfo?(nchen)
nsIWebNavigation.loadURI actually has an optional triggering principal
parameter that RemoteWebNavigation hasn't implemented. This patch adds
the extra parameter to RemoteWebNavigation's implementation so
triggering principals are passed properly when loadURI is called with
a triggering principal.
When defaulting to a null triggering principal, these tests would fail
when loaded remotely. This patch adds explicit system triggering
principal to the loadURI calls.
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c4a8a6256d7f
1. Serialize default null principal in RemoteWebNavigation; r=jkt
https://hg.mozilla.org/integration/autoland/rev/670b75f8446f
2. Default to null triggering principal for GeckoView.loadUri; r=esawin
https://hg.mozilla.org/integration/autoland/rev/7b5505d44965
3. Disable Necko IPC security for test_saveHeapSnapshot_e10s_01; r=fitzgen
https://hg.mozilla.org/integration/autoland/rev/bc592bed0522
4. Add triggering principal parameter to RemoteWebNavigation.loadURI; r=jkt
https://hg.mozilla.org/integration/autoland/rev/2c1353f4a3f5
5. Pass explicit triggering principal in more places; r=jkt
Backout by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/47e77fc9d699
Backed out 5 changesets for chrome failure at toolkit/content/tests/chrome/test_findbar_events.xul. on a CLOSED TREE
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/243b8450ba00
1. Serialize default null principal in RemoteWebNavigation; r=jkt
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4464cd48336
2. Default to null triggering principal for GeckoView.loadUri; r=esawin
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f98cec81e6b
3. Disable Necko IPC security for test_saveHeapSnapshot_e10s_01; r=fitzgen
https://hg.mozilla.org/integration/mozilla-inbound/rev/0fb606cf70a0
4. Add triggering principal parameter to RemoteWebNavigation.loadURI; r=jkt
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd2a304f5fe9
5. Pass explicit triggering principal in more places; r=jkt
64=wontfix because we don't need to uplift these test fixes.
status-geckoview64=wontfix
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 65 → mozilla65
Depends on: 1573860
You need to log in before you can comment on or make changes to this bug.