Closed
Bug 1496226
Opened 3 years ago
Closed 3 years ago
Be sure raptor's capturing of first-contentful-paint in google chrome is the correct entry
Categories
(Testing :: Raptor, defect)
Tracking
(firefox64 fixed)
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: rwood, Assigned: rwood)
References
Details
Attachments
(1 file)
As :jesup pointed out (thanks!), when getting 'first-contentful-paint' on google chrome, currently raptor is using the perfData.getEntriesByType("paint") and accepting the entry returned [1]. However turns out on google chrome, the entry type of 'paint' is correct however there are two 'paint' entries - there is an entry.name subfield for "first-paint" or "first-contentful-paint". So raptor needs to make sure it is getting the correct one instead of taking the first one. [1] https://searchfox.org/mozilla-central/rev/3c85ea2f8700ab17e38b82d77cd44644b4dae703/testing/raptor/webext/raptor/measure.js#187
Assignee | ||
Comment 1•3 years ago
|
||
For more info see: https://developer.mozilla.org/en-US/docs/Web/API/PerformancePaintTiming i.e. need to check the PerformanceEntry.name and ensure it is 'first-contentful-paint' when measuring FCP on chrome.
Assignee | ||
Updated•3 years ago
|
Assignee: nobody → rwood
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8cb7c7062ac36ed9d652e30fe94b4b2d185b6798
Assignee | ||
Comment 3•3 years ago
|
||
Pushed by rwood@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e742cc754ebc Be sure raptor's capturing of first-contentful-paint in google chrome is the correct entry; r=jmaher
Comment 5•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e742cc754ebc
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•