Closed Bug 1496226 Opened 2 years ago Closed 2 years ago
Be sure raptor's capturing of first-contentful-paint in google chrome is the correct entry
Bug 1496226 - Be sure raptor's capturing of first-contentful-paint in google chrome is the correct entry; r?jmaher
46 bytes, text/x-phabricator-request
|Details | Review|
As :jesup pointed out (thanks!), when getting 'first-contentful-paint' on google chrome, currently raptor is using the perfData.getEntriesByType("paint") and accepting the entry returned . However turns out on google chrome, the entry type of 'paint' is correct however there are two 'paint' entries - there is an entry.name subfield for "first-paint" or "first-contentful-paint". So raptor needs to make sure it is getting the correct one instead of taking the first one.  https://searchfox.org/mozilla-central/rev/3c85ea2f8700ab17e38b82d77cd44644b4dae703/testing/raptor/webext/raptor/measure.js#187
For more info see: https://developer.mozilla.org/en-US/docs/Web/API/PerformancePaintTiming i.e. need to check the PerformanceEntry.name and ensure it is 'first-contentful-paint' when measuring FCP on chrome.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/e742cc754ebc Be sure raptor's capturing of first-contentful-paint in google chrome is the correct entry; r=jmaher
You need to log in before you can comment on or make changes to this bug.