1496238 - [BinAST] Allow running BinAST in jit-tests

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Eric Faust [:efaust]]

Seems like it'll be useful to have some saved runtime tests, for things like laziness and interesting hand-rolled tests.

Comment 1

[Eric Faust [:efaust]]

Attachment: Fix

I'm not thrilled about the poor man's skip-if, but we don't support skip-if as a directive.

If we had that, we could stick a directives.txt in the intended file.

Tested locally, with and without binast builds.

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 9014199 [details] [diff] [review]
Fix

Review of attachment 9014199 [details] [diff] [review]:
-----------------------------------------------------------------

I'm thrilled about it. Big thumbs up.

Comment 3

[Eric Faust [:efaust]]

Attachment: Part 2: Allow foo.binjs to keep directives in foo.dir

Comment 4

[Eric Faust [:efaust]]

Part 2 was directly requested by arai for transcoding the existing suite.

Comment 5

[Jeff Walden [:Waldo]]

Comment on attachment 9014259 [details] [diff] [review]
Part 2: Allow foo.binjs to keep directives in foo.dir

Review of attachment 9014259 [details] [diff] [review]:
-----------------------------------------------------------------

fnord

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/105ad7200afc
Part 1: Allow runtime BinAST testing with jit_tests. (r=jorendorff)
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d07362984d4
Part 2: Allow BinAST directives files in jit_tests. (r=Waldo)

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/105ad7200afc
https://hg.mozilla.org/mozilla-central/rev/4d07362984d4