Closed Bug 1496238 Opened 1 year ago Closed 1 year ago

[BinAST] Allow running BinAST in jit-tests

Categories

(Core :: JavaScript Engine, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: efaust, Assigned: efaust)

Details

Attachments

(2 files)

Seems like it'll be useful to have some saved runtime tests, for things like laziness and interesting hand-rolled tests.
Attached patch FixSplinter Review
I'm not thrilled about the poor man's skip-if, but we don't support skip-if as a directive.

If we had that, we could stick a directives.txt in the intended file.

Tested locally, with and without binast builds.
Assignee: nobody → efaustbmo
Status: NEW → ASSIGNED
Attachment #9014199 - Flags: review?(jorendorff)
Comment on attachment 9014199 [details] [diff] [review]
Fix

Review of attachment 9014199 [details] [diff] [review]:
-----------------------------------------------------------------

I'm thrilled about it. Big thumbs up.
Attachment #9014199 - Flags: review?(jorendorff) → review+
Part 2 was directly requested by arai for transcoding the existing suite.
Comment on attachment 9014259 [details] [diff] [review]
Part 2: Allow foo.binjs to keep directives in foo.dir

Review of attachment 9014259 [details] [diff] [review]:
-----------------------------------------------------------------

fnord
Attachment #9014259 - Flags: review?(jorendorff) → review+
Pushed by efaustbmo@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/105ad7200afc
Part 1: Allow runtime BinAST testing with jit_tests. (r=jorendorff)
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d07362984d4
Part 2: Allow BinAST directives files in jit_tests. (r=Waldo)
Priority: -- → P2
https://hg.mozilla.org/mozilla-central/rev/105ad7200afc
https://hg.mozilla.org/mozilla-central/rev/4d07362984d4
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.