Closed
Bug 1496274
Opened 7 years ago
Closed 7 years ago
[wpt-sync] Sync PR 13345 - [LayoutNG] Correct clip-path reference box calculation.
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 13345 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/13345
Details from upstream follow.
Morten Stenshorne <mstensho@chromium.org> wrote:
> [LayoutNG] Correct clip-path reference box calculation.
>
> We used coordinates relatively to the line box, while we were expected
> by the caller to be relative to the containing block. Flipping for
> writing mode was bogus for NG (but needed by legacy), since NG uses
> truly physical coordinates.
>
> Hardened tests to contain a leading line and padding, and leading
> content on the first line of the clipped child.
>
> Bug: 641907
> Change-Id: I2b1b9ff4ea92a6405fcdffcf139842458b46442f
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
>
> Reviewed-on: https://chromium-review.googlesource.com/1257913
> WPT-Export-Revision: 3d54b3980d82f5543950ae924fdac97685e1d25d
| Assignee | ||
Comment 1•7 years ago
|
||
PR 13345 applied with additional changes from upstream: 123dbad2221a34797cd146cbaeaff50c04c6dded
| Assignee | ||
Updated•7 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
| Assignee | ||
Comment 2•7 years ago
|
||
| Assignee | ||
Comment 3•7 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=002ab9121e32daee8556557287c7cfcf20c9bf72
| Assignee | ||
Comment 4•7 years ago
|
||
Ran 3 tests
FAIL : 3
New tests that have failures or other problems:
/css/css-masking/clip-path/clip-path-inline-001.html: FAIL
/css/css-masking/clip-path/clip-path-inline-002.html: FAIL
/css/css-masking/clip-path/clip-path-inline-003.html: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/13844f50ee32
[wpt PR 13345] - [LayoutNG] Correct clip-path reference box calculation., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/34559e14034d
[wpt PR 13345] - Update wpt metadata, a=testonly
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/13844f50ee32
https://hg.mozilla.org/mozilla-central/rev/34559e14034d
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•