Closed Bug 1496279 Opened 6 years ago Closed 6 years ago

ImageLoader::RegisterCSSImage doesn't need to be called on loading document when printing

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: heycam, Assigned: heycam)

Details

Attachments

(1 file)

For a print document, we load any CSS images using the original document's ImageLoader.  We also register the CSS image with that ImageLoader but since that only has the effect of finding those image when a test is asked to flush use counters for them, I don't think we need to do that.
I tried removing the loading document registration and printing a document that had some images that were only used in a `@media print` rule and it seemed to work fine.
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b7ba9bbad14
Don't register CSS images in the loading document when printing r=emilio
https://hg.mozilla.org/mozilla-central/rev/3b7ba9bbad14
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: