1496282 - Crash on audiounit_output_callback if open cubeb log

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P2)

Description

[Alastor Wu [:alwu]]

STR.
1. run $ MOZ_LOG=cubeb:5 ./mach run 
2. open https://bug1262276.bmoattachments.org/attachment.cgi?id=8738531

Expect.
3. no crash

Actual.
3. crash (crash also happen on other webm files)

---

Process 20908 stopped
* thread #72, queue = 'com.apple.root.user-initiated-qos', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
    frame #0: 0x0000000106499f22 XUL`::___ZL25audiounit_output_callbackPvPjPK14AudioTimeStampjjP15AudioBufferList_block_invoke(.block_descriptor=0x000000013af1f0c0) at cubeb_audiounit.cpp:584 [opt]
   581
   582 	  cubeb_stream * stm = static_cast<cubeb_stream *>(user_ptr);
   583
-> 584 	  ALOGV("(%p) output: buffers %u, size %u, channels %u, frames %u, total input frames %lu.",
   585 	        stm,
   586 	        (unsigned int) outBufferList->mNumberBuffers,
   587 	        (unsigned int) outBufferList->mBuffers[0].mDataByteSize,
Target 0: (firefox) stopped.
(lldb) bt
* thread #72, queue = 'com.apple.root.user-initiated-qos', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
  * frame #0: 0x0000000106499f22 XUL`::___ZL25audiounit_output_callbackPvPjPK14AudioTimeStampjjP15AudioBufferList_block_invoke(.block_descriptor=0x000000013af1f0c0) at cubeb_audiounit.cpp:584 [opt]
    frame #1: 0x00007fff54af35fa libdispatch.dylib`_dispatch_call_block_and_release + 12
    frame #2: 0x00007fff54aebdb8 libdispatch.dylib`_dispatch_client_callout + 8
    frame #3: 0x00007fff54aedb2c libdispatch.dylib`_dispatch_root_queue_drain + 902
    frame #4: 0x00007fff54aed755 libdispatch.dylib`_dispatch_worker_thread3 + 101
    frame #5: 0x00007fff54e3d169 libsystem_pthread.dylib`_pthread_wqthread + 1387
    frame #6: 0x00007fff54e3cbe9 libsystem_pthread.dylib`start_wqthread + 13
(lldb) p stm
(cubeb_stream *) $0 = 0x0000000100603b60

Comment 1

[Alex Chronopoulos [:achronop]]

The stm->input_linear_buffer in [1] must be NULL on playback case. I'll test it here but I think it will be easy to repro even with a stand alone cubeb app.

[1] https://searchfox.org/mozilla-central/source/media/libcubeb/src/cubeb_audiounit.cpp#590

Comment 2

[Paul Adenot (:padenot)]

Merged upstream: https://github.com/kinetiknz/cubeb/pull/460#event-1884346555

Comment 3

[Paul Adenot (:padenot)]

P2, likely blocking Alastor's work.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:padenot, could you have a look please?
For more information, please visit auto_nag documentation.