1496313 - Land tests for setting the fill mode on the compositor

Status: NEW

(Core :: DOM: Animation, defect, P3)

Description

[Brian Birtles (:birtles)]

The tests I am adding in bug 1495350 occasionally fail on try with the following error:

  INFO TEST-UNEXPECTED-FAIL | dom/animation/test/mozilla/test_style_after_finished_on_compositor.html | Opacity animation when playing forwards uses fill: forwards while waiting for the main thread to catch up - Opacity animation when playing forwards uses fill: forwards while waiting for the main thread to catch up: assert_not_equals: The animation style is applied on the compositor got disallowed value ""

It seems to only occur on the first backwards-playing animation (although I suspect it could happen on the other backwards-playing animation too).

I don't really want to block landing that bug on fixing this since I can't reproduce it locally and it might take a long time to debug on try.

I suspect it's some sort of precision issue where the animation is precisely at the end and we're failing a <= comparison that would make the animation be treated as a candidate for sending to the compositor.

Incidentally, if that is the case, the following spec issue might actually make that condition less likely to occur:

  https://github.com/w3c/csswg-drafts/issues/3193

For now I'm just going to make those tests bail if we don't have the animation on the compositor in time.

Comment 1

[Brian Birtles (:birtles)]

In bug 1495350 I ended up just landing the code changes without the tests. I'll use this bug for landing the tests.

Comment 2

[Brian Birtles (:birtles)]

Attachment: Tests