1496321 - Alert summaries with unknown revisions

Status: RESOLVED FIXED

(Tree Management :: Perfherder, enhancement, P1)

Description

[Ionuț Goldan [:igoldan]]

For at least the last 2 weeks, occasional alert summaries with "Unknown revision(s)" started to show up. This smells like a bug, so we need to investigate & fix this issues.

Examples:
https://treeherder.mozilla.org/perf.html#/alerts?id=16342
https://treeherder.mozilla.org/perf.html#/alerts?id=16386

Comment 1

[Ionuț Goldan [:igoldan]]

I noticed this happens when we're looking over them from the Alerts page: https://treeherder.mozilla.org/perf.html#/alerts?status=9&framework=1&hideDwnToInv=1&page=1

Comment 2

[Ionuț Goldan [:igoldan]]

(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #1)
> I noticed this happens when we're looking over them from the Alerts page:
> https://treeherder.mozilla.org/perf.html#/
> alerts?status=9&framework=1&hideDwnToInv=1&page=1

This may be just a Angular/Javascript issue.

Comment 3

[Sarah Clements [:sclements]]

I noticed this also while converting the Alerts table header (there was a code comment in the alerts partial that suggested the red "Unknown revision(s)" should only show up in development mode). After investigating, it turns out the revision information for those alerts isn't being returned by the Push API because there is a default of count=10 set for the API. This will be remedied by explicitly setting the count param accordingly (since we're querying for multiple push_ids at a time). I'll include the fix in my next conversion PR.

Comment 4

[Sarah Clements [:sclements]]

This has been fixed in this pr: https://github.com/mozilla/treeherder/pull/5005