[Windows 10 1809] 1px top-border is colored even when "Show accent color in titlebar and borders" is disabled

VERIFIED FIXED in Firefox -esr60

Status

()

defect
P1
normal
VERIFIED FIXED
9 months ago
8 months ago

People

(Reporter: ge3k0s, Assigned: dao)

Tracking

(Depends on 1 bug, Blocks 1 bug)

62 Branch
Firefox 64
All
Windows 10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr6063+ verified, firefox62 wontfix, firefox63+ verified, firefox64+ verified)

Details

Attachments

(6 attachments)

Reporter

Description

9 months ago
From Windows October 2018 Update (1809 build 17763.1) and on the 1px border around windows isn't colored by default anymore. If titlebar and borders' color is disabled there is a black-grey border around the window instead.

Firefox continues to draw a colored 1px border on top of the window and it looks a bit odd (see attachment).
Reporter

Updated

9 months ago
Summary: [Windows October 2018 Update] 1px top-border is colored even when borders color is disabled → [Windows 10 October 2018 Update] 1px top-border is colored even when borders color is disabled

Comment 1

9 months ago
(In reply to Ge3k0s from comment #0)
> Created attachment 9014281 [details]
> 1px top-border visual annoyance.png
> 
> From Windows October 2018 Update (1809 build 17763.1) and on the 1px border
> around windows isn't colored by default anymore. If titlebar and borders'
> color is disabled there is a black-grey border around the window instead.

These 2 sentences don't make a lot of sense to me taken together. It sounds like there are multiple options for how Windows can behave. It's not clear to me if you're referring to the options to automatically change the titlebar colour based on the (changing) desktop background, or if there's a new option, or something else. It's also not clear to me if there are only problems with some combination of options, or if some widget-y part of Windows changed and now we look wrong no matter how the user configured their device.

I'm also on the Insider Fast ring and haven't noticed anything, though it's obviously possible I've just not noticed.

Please can you provide more specifics?
Flags: needinfo?(ge3k0s)
Reporter

Comment 2

9 months ago
Posted image Windows settings.png
(In reply to :Gijs (he/him) from comment #1)
> (In reply to Ge3k0s from comment #0)
> > Created attachment 9014281 [details]
> > 1px top-border visual annoyance.png
> > 
> > From Windows October 2018 Update (1809 build 17763.1) and on the 1px border
> > around windows isn't colored by default anymore. If titlebar and borders'
> > color is disabled there is a black-grey border around the window instead.
> 
> These 2 sentences don't make a lot of sense to me taken together. It sounds
> like there are multiple options for how Windows can behave. It's not clear
> to me if you're referring to the options to automatically change the
> titlebar colour based on the (changing) desktop background, or if there's a
> new option, or something else. It's also not clear to me if there are only
> problems with some combination of options, or if some widget-y part of
> Windows changed and now we look wrong no matter how the user configured
> their device.
> 
> I'm also on the Insider Fast ring and haven't noticed anything, though it's
> obviously possible I've just not noticed.
> 
> Please can you provide more specifics?

Yes sorry for the confusion : in fact there are multiple options. Since Windows 10 1809 in Windows setting "Show accent color in titlebar" has become "Show accent color in titlebar and borders". The issue doesn't seem to be related to the other options "Choose accent color from the background image".

When the "Show accent color in titlebar and borders" is disabled (see screenshot, sorry my system is in French), the new default way to handle borders make them grey-black. Firefox is the only application on my desktop that keeps the top-border colored.
Flags: needinfo?(ge3k0s)
Reporter

Comment 3

9 months ago
Here's a small comparison between the two options.

Note that depending on the chosen accent color the 1px colored top-border is more or less visible.
Reporter

Updated

9 months ago
Summary: [Windows 10 October 2018 Update] 1px top-border is colored even when borders color is disabled → [Windows 10 October 2018 Update] 1px top-border is colored even when "Show accent color in titlebar and borders" is disabled
Assignee

Updated

9 months ago
Assignee: nobody → dao+bmo
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P1
Assignee

Comment 4

9 months ago
[Tracking Requested - why for this release]: Windows 10 1809 release
Reporter

Comment 6

8 months ago
FWIW Windows 10 1809 has been momentarily pulled from Windows update due to a files loss issue. It would be nice to have this fix for 63 at least though.
Reporter

Updated

8 months ago
Flags: needinfo?(gijskruitbosch+bugs)
Dao, can we get a an update on this (last beta for 63 goes to build later today)? Thanks
Flags: needinfo?(dao+bmo)
Assignee

Comment 8

8 months ago
I'm working on it.
Flags: needinfo?(gijskruitbosch+bugs)
Flags: needinfo?(dao+bmo)

Comment 10

8 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/92f90717c2a7
Update window border colors for Windows 10 1809 update. r=Gijs
Assignee

Updated

8 months ago
Blocks: 1498213
Assignee

Updated

8 months ago
Flags: qe-verify+
Reporter

Comment 11

8 months ago
I'm not sure to correctly understand the patch but as seen on the screenshots it seems to make the color accent used even when it's disabled system wide. I think the right solution would be to respect the Windows setting and make the border gray-black in this case. Microsoft long term plan with Fluent design seems to consist in the use of a "depth shadow" as borders.

Comment 12

8 months ago
(In reply to Ge3k0s from comment #11)
> I'm not sure to correctly understand the patch but as seen on the
> screenshots 


As noted in comment #9, the screenshots are from pre-1809 builds

> it seems to make the color accent used even when it's disabled
> system wide.

It's based on the same pref comment #0 references, so I think this matches what other apps do pre-1809.
Reporter

Comment 13

8 months ago
(In reply to :Gijs (he/him) from comment #12)
> (In reply to Ge3k0s from comment #11)
> > I'm not sure to correctly understand the patch but as seen on the
> > screenshots 
> 
> 
> As noted in comment #9, the screenshots are from pre-1809 builds

Ah sorry missed that.

(In reply to :Gijs (he/him) from comment #12)
> (In reply to Ge3k0s from comment #11)
> > it seems to make the color accent used even when it's disabled
> > system wide.
> 
> It's based on the same pref comment #0 references, so I think this matches
> what other apps do pre-1809.

So it should have black borders post 1809 like the other apps ?

Comment 14

8 months ago
(In reply to Ge3k0s from comment #13)
> So it should have black borders post 1809 like the other apps ?

Unless the "Show accent color in titlebar and borders" pref is turned on, yes.
Reporter

Comment 15

8 months ago
(In reply to :Gijs (he/him) from comment #14)
> (In reply to Ge3k0s from comment #13)
> > So it should have black borders post 1809 like the other apps ?
> 
> Unless the "Show accent color in titlebar and borders" pref is turned on,
> yes.

Thanks for the answer and sorry for the misunderstanding.
Assignee

Updated

8 months ago
Summary: [Windows 10 October 2018 Update] 1px top-border is colored even when "Show accent color in titlebar and borders" is disabled → [Windows 10 1809] 1px top-border is colored even when "Show accent color in titlebar and borders" is disabled
Assignee

Comment 16

8 months ago
Comment on attachment 9014379 [details]
Bug 1496322 - Update window border colors for Windows 10 1809 update. r?gijs

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: 1366405 / Windows 10 1809 release

User impact if declined: See comment 0

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: Need to test Windows 10 1809 and 1803, with and without "Show accent color in titlebar [and borders]" enabled.

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): The patch is fairly simple, so I think with some careful testing we'll be good.

String changes made/needed:
Attachment #9014379 - Flags: approval-mozilla-beta?
Comment on attachment 9014379 [details]
Bug 1496322 - Update window border colors for Windows 10 1809 update. r?gijs

Uplift accepted for our last 63 beta as this is a very visible visual bug on our primary UI on this new Windows version, thanks.
Attachment #9014379 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 19

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/92f90717c2a7
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
I have attempted to reproduce and verify this issue on Microsoft Surface with Windows 10 Pro Version 1809:

The results of the affected build (Nightly v64.0a1 from 2018-10-10) are as follows:
1a. Windows preference "Title bars and window borders" on:
 - when the window is selected: light blue title bar
 - when the window is deselected: gray title bar
1b. Windows preference "Show accent color" on "Title bars and window borders" off:
 - when the window is selected: dark blue and a 1px line above the title bar
 - when the window is deselected: dark blue title bar

The results of the unaffected/fixed build (Nightly v64.0a1 from 2018-10-14) are as follows:
2a. Windows preference "Title bars and window borders" on:
 - when the window is selected: light blue title bar
 - when the window is deselected: gray title bar
2b. Windows preference "Show accent color" on "Title bars and window borders" off:
 - when the window is selected: dark blue and a 1px line above the title bar
 - when the window is deselected: dark blue title bar

In conclusion, I see no difference in the behavior of the builds prior to and after the fix on Windows 10 v1809.
@Dao, am I missing anything? 

Considering the uplift request from comment 16, the STR to check is "Need to test Windows 10 1809 and 1803, with and without "Show accent color in title bar [and borders]" enabled.", I deduce that the 1px light blue line shown on top of the title bar when the window is selected should not be displayed anymore. Is that correct? Please make me understand the actual and expected results.
Flags: needinfo?(dao+bmo)
Assignee

Comment 21

8 months ago
(In reply to Bodea Daniel [:danibodea] from comment #20)
> I have attempted to reproduce and verify this issue on Microsoft Surface
> with Windows 10 Pro Version 1809:
> 
> The results of the affected build (Nightly v64.0a1 from 2018-10-10) are as
> follows:
> 1a. Windows preference "Title bars and window borders" on:
>  - when the window is selected: light blue title bar
>  - when the window is deselected: gray title bar
> 1b. Windows preference "Show accent color" on "Title bars and window
> borders" off:
>  - when the window is selected: dark blue and a 1px line above the title bar
>  - when the window is deselected: dark blue title bar
> 
> The results of the unaffected/fixed build (Nightly v64.0a1 from 2018-10-14)
> are as follows:
> 2a. Windows preference "Title bars and window borders" on:
>  - when the window is selected: light blue title bar
>  - when the window is deselected: gray title bar
> 2b. Windows preference "Show accent color" on "Title bars and window
> borders" off:
>  - when the window is selected: dark blue and a 1px line above the title bar
>  - when the window is deselected: dark blue title bar

The 1px line above the title bar shouldn't be there on 1809.
Flags: needinfo?(dao+bmo)

Comment 22

8 months ago
FWIW, I just doublechecked - I could reproduce the original issue on a restored window with Nightly 10/10 and an older 63 beta, and can't reproduce anymore with 63 beta 14 or 64 nightly from 15/10, on Windows 1809, insider 18252.1000 (installed Oct 6).

I don't know why I'm seeing something else than comment #20. Ge3k0s, can you check 63 beta and nightly on your end and tell us what you're seeing?

:danibodea, any idea what could be different on your machine? Did you restart Firefox/Nightly after unticking "Title bars and window borders" in "Show the accent color on the following surfaces" ? In the case where you see the line, if you open the browser console (enable devtools.chrome.enabled in about:config first if necessary) and run:

TelemetryEnvironment.currentEnvironment.system.os

what's the output?
Flags: needinfo?(ge3k0s)
Flags: needinfo?(daniel.bodea)
(In reply to :Gijs (he/him) from comment #22)
> :danibodea, any idea what could be different on your machine? Did you
> restart Firefox/Nightly after unticking "Title bars and window borders" in
> "Show the accent color on the following surfaces" ? In the case where you
> see the line, if you open the browser console (enable
> devtools.chrome.enabled in about:config first if necessary) and run:
> 
> TelemetryEnvironment.currentEnvironment.system.os
> 
> what's the output?

Yes, I did restart the browser after modifying the Windows preference (unticking the "Title bars and window borders" from the "Show accent color on the following surfaces" section). I have to mention that the 1px color accent line is easily camouflaged in the color contrast (if a very light color is in the background of the browser and the title bar is light or dark blue, then the 1px line will not be observable; a dark background is needed in order to check the issue).
Flags: needinfo?(daniel.bodea)
When running the "TelemetryEnvironment.currentEnvironment.system.os" command, the following message is displayed: see attached photo.
Assignee

Comment 25

8 months ago
(In reply to Bodea Daniel [:danibodea] from comment #24)
> Created attachment 9017422 [details]
> surface system and os proof.jpg
> 
> When running the "TelemetryEnvironment.currentEnvironment.system.os"
> command, the following message is displayed: see attached photo.

You're running build 17760 which is an obsolete insider preview. Probably not worth catering for; you should get an update.
Reporter

Comment 26

8 months ago
(In reply to :Gijs (he/him) from comment #22)
> FWIW, I just doublechecked - I could reproduce the original issue on a
> restored window with Nightly 10/10 and an older 63 beta, and can't reproduce
> anymore with 63 beta 14 or 64 nightly from 15/10, on Windows 1809, insider
> 18252.1000 (installed Oct 6).
> 
> I don't know why I'm seeing something else than comment #20. Ge3k0s, can you
> check 63 beta and nightly on your end and tell us what you're seeing?

I checked with latest Nightly and the 1px top-border isn't colored anymore. 

It isn't perfect though since there is now a black border on top that isn't present around the rest of the window and isn't really visually pleasing.
Flags: needinfo?(ge3k0s)
I have updated the Windows on the Microsoft Surface and now it's running build 18252.1000; It's apparently the last available OS build update. I can now verify the fix in Nightly v64.0a1 from 2018-10-15. The 1px light blue line above the title bar is only displayed if the Windows setting "Title bars and window borders"  from the "Show accent color on the following surfaces" is ON.

I have also verified the fix in Beta v63.0b14. The 1px light blue line is not displayed when the relevant windows preference is turned off.

This issue is now fully verified. Thank you.
Status: RESOLVED → VERIFIED

Comment 28

8 months ago
(In reply to Ge3k0s from comment #26)
> It isn't perfect though since there is now a black border on top that isn't
> present around the rest of the window and isn't really visually pleasing.

Can you file a follow-up issue with more details? I'm confused, given comment #2 says "the new default way to handle borders make them grey-black" and I see those borders around the rest of the window, and also on other apps...
Flags: needinfo?(ge3k0s)
Assignee

Comment 29

8 months ago
(In reply to :Gijs (he/him) from comment #28)
> (In reply to Ge3k0s from comment #26)
> > It isn't perfect though since there is now a black border on top that isn't
> > present around the rest of the window and isn't really visually pleasing.
> 
> Can you file a follow-up issue with more details? I'm confused, given
> comment #2 says "the new default way to handle borders make them grey-black"
> and I see those borders around the rest of the window, and also on other
> apps...

This is basically bug 1405228. We draw the border within the window so at the moment there's no way to make it look perfectly native.
Assignee

Updated

8 months ago
Flags: needinfo?(ge3k0s)
Assignee

Comment 31

8 months ago
[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: Primary UI glitch after Windows 10 1809 release

User impact if declined: see comment 0

Fix Landed on Version: Nightly 64 and Beta 63

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): The patch is fairly simple, so I think with some careful testing we'll be good.

String or UUID changes made by this patch:
Attachment #9017536 - Flags: approval-mozilla-esr60?
Assignee

Comment 32

8 months ago
(In reply to Dão Gottwald [::dao] from comment #16)
> If yes, steps to reproduce: Need to test Windows 10 1809 and 1803, with and
> without "Show accent color in titlebar [and borders]" enabled.

Daniel, do you have access to a machine with build 1803? That's the April 2018 update.
Flags: needinfo?(daniel.bodea)
Reorganizing testing results:

Microsoft Surface Pro 2 i5 (with Windows 10 version 1809):
1. Nightly v64.0a1
a. Windows pref on
 - selected: 1 px blue line is displayed around the browser window
 - unselected: no blue line

b. Windows pref off
 - selected: no blue line
 - unselected: no blue line

2. Beta v63.0b14
a. Windows pref on
 - selected: 1 px blue line is displayed around the browser window
 - unselected: : no blue line

b. Windows pref off
 - selected: no blue line
 - unselected: no blue line

3. ESR60.3 try build
a. Windows pref on
 - selected: 1 px blue line is displayed around the browser window
 - unselected: : no blue line

b. Windows pref off
 - selected: no blue line
 - unselected: no blue line


Microsoft Surface Pro 4 (with Windows 10 version 1803):
1. Nightly v64.0a1
a. Windows pref on
 - selected:  1 px blue line is displayed around the browser window
 - unselected: no blue line

b. Windows pref off
 - selected: 1 px blue line is displayed around the browser window
 - unselected: no blue line

2. Beta v63.0b14
a. Windows pref on
 - selected: 1 px blue line is displayed around the browser window
 - unselected: no blue line

b. Windows pref off
 - selected: 1 px blue line is displayed around the browser window
 - unselected: no blue line

3. ESR60.3 try build
a. Windows pref on
 - selected: 1 px blue line is displayed around the browser window
 - unselected: : no blue line

b. Windows pref off
 - selected: 1 px blue line is displayed around the browser window
 - unselected: no blue line

Are these the expected results? C
an I also mark flag firefox-esr60 as verified?
Flags: needinfo?(daniel.bodea)
Reporter

Comment 34

8 months ago
(In reply to :Gijs (he/him) from comment #28)
> (In reply to Ge3k0s from comment #26)
> > It isn't perfect though since there is now a black border on top that isn't
> > present around the rest of the window and isn't really visually pleasing.
> 
> Can you file a follow-up issue with more details? I'm confused, given
> comment #2 says "the new default way to handle borders make them grey-black"
> and I see those borders around the rest of the window, and also on other
> apps...

Yes but that also makes them a lot less visible. In this case the top border is considerably thicker than in other apps (Win32 and UWP FWIW).

You can clearly see the difference if you enable the titlebar in Firefox and looks at the top border. I don't know if it's really linked to bug 1405228 that mentions inactive windows.
Reporter

Updated

8 months ago
Depends on: 1499439
Reporter

Comment 35

8 months ago
I filed bug 1499439 as a follow-up.
No longer depends on: 1499439
Comment on attachment 9017536 [details] [diff] [review]
patch for esr60

Fixes a new UI regression in Win10 1809. Approved for 60.3esr.
Attachment #9017536 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
I have verified the fix in the latest v60.3esr build from Taskcluster which contains the fix:
https://index.taskcluster.net/v1/task/gecko.v2.mozilla-esr60.latest.firefox.win64-opt/artifacts/public/build/target.zip

The same results as the ones from the try build in comment 33. 
This issue is now verified in firefox-esr60. Thank you.
Assignee

Updated

8 months ago
Depends on: 1405228
You need to log in before you can comment on or make changes to this bug.