Closed Bug 1496338 Opened Last year Closed Last year
Tab bar context menu should read "Bookmark selected tab" if only one tab is selected
Bug 1496338 - Tab bar context menu should read 'Bookmark Selected Tab...' if only one tab is selected. r?Felipe
46 bytes, text/x-phabricator-request
|Details | Review|
STR: 1. Don't have multiple tabs selected 2. Right click empty area of tab bar AR: There is a `Bookmark selected tabs...` item. ER: Looking at the other items in this menu, I think it should be `Bookmark all tabs`.
There is always at least one tab that is selected, which is what would get bookmarked if "Bookmark Selected Tabs..." is clicked. Reload All Tabs will get changed to Reload Selected Tabs by bug 1480532.
Status: UNCONFIRMED → RESOLVED
Closed: Last year
Resolution: --- → INVALID
Not to revive a dead bug, but I was confused by the menu item and was about to file a bug before finding this one. Would it maybe make sense to instead say "Bookmark current tab" or "Bookmark active tab" in the case of one tab selected? The user might not realise that the current tab counted as selected.
I think at least 'Bookmark Selected Tabs' should change to 'Bookmark Selected Tab' (singular) when not in a multi-selected context.
(In reply to Bruce from comment #3) > I think at least 'Bookmark Selected Tabs' should change to 'Bookmark > Selected Tab' (singular) when not in a multi-selected context. I think this would indeed remove most of the confusion, though it is a bit subtle. I'll reopen this bug to tweak the wording.
Status: RESOLVED → REOPENED
Ever confirmed: true
QA Contact: dao+bmo
Resolution: INVALID → ---
Summary: "Bookmark selected tabs" shown in tab bar context menu even if no tabs are selected → Tab bar context menu should read "Bookmark selected tab" if only one tab is selected
Status: REOPENED → NEW
Priority: -- → P5
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/ab824c7f0dd9 Tab bar context menu should read 'Bookmark Selected Tab...' if only one tab is selected. r=Felipe
Verified in Nightly Build ID 20181017101626 User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0
Verified fixed that this implementation is present on the latest Nightly Nightly 65.0a1(2018-11-22)and the latest Beta 64.0b12 as well .
You need to log in before you can comment on or make changes to this bug.