1496366 - Clean up win10 hardware manifests

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: OpenCloudConfig, task)

Description

[Pete Moore [:pmoore][:pete]]

Currently the following manifest files exist for gecko-t-win10-64-hw:

  i)  userdata/Manifest/gecko-t-win10-64-hw-GW10.json
  ii) userdata/Manifest/gecko-t-win10-64-hw.json

I believe the following changes are needed (please correct me if I'm wrong):

1) ii) is no longer used and can be deleted
2) i) is for worker type gecko-t-win10-64-hw and therefore should be renamed to gecko-t-win10-64-hw.json
3) the generic-worker version in i) is currently 10.8.5 and should be bumped to 10.11.2 to be consistent with the other worker types. **Please note** that also requires changing the sha512 from "f26832cf...." to "c2c3b75a....", *and* changing the version verification ("Like": "generic-worker 10.8.5 *" -> "Like": "generic-worker 10.11.2 *")

I see we also have other active worker types that have no manifest file:

releng-hardware/gecko-t-win10-64-ux:  running generic-worker 10.8.5
releng-hardware/gecko-t-win10-64-uxb: running generic-worker 10.8.5

so I believe we should probably add manifest files for these two worker types, and also bump them to version 10.11.2 too.

Many thanks!

Comment 1

[Mark Cornmesser [:markco]]

I have patch in the works that address the removal of i) and the addition of gecko-t-win10-64-ux.json. It will include some additional clean up removing other portions that where involved in supporting the 2 versions of generic-worker on hardware. This is currently in this repo: https://github.com/mozilla-platform-ops/OpenCloudConfig . 

As for the worker version. For the moonshots, I have not had the opportunity to tests the newer generic-worker version. Because of the myriad hardware issues, Bug 1490398 in particular, I have been pushing this off. 

I will go ahead and bump the workerType ux to 10.11.2 on Monday. Note that these are not yet in production.

Comment 2

[Mark Cornmesser [:markco]]

Attachment: GitHub Pull Request

This covers upgrading generic-worker 10.11.2 and adding support for the -ux workers (AreWeFastYet laptops). 


The changes shown for gecko-t-win10-64-hw.json is misleading. The original gecko-t-win10-64-hw.json was deleted and the gecko-t-win10-64-hw-G10.json was renamed to replace it. As well as it was copied over for the use as the ux manifest .

Here is a try push that used generic-worker 10.11.2 on hardware:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=61f9eff74bbb757296f96b987c69aff85bc2fec2

jmaher: Any concerns on your side if we upgrade generic-worker this week?

Comment 3

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Comment on attachment 9017087 [details] [review]
GitHub Pull Request

lgtm
please use githubs "squash and merge" feature to keep the master branch history tidy.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

:markco, thanks for checking- I think upgrading the worker would be fine- one thing to be careful is that we have our next uplift taking place next week and this week is the "pre-release", so if we have a lot of back and forth/downtime/shifting in numbers, it can be confusing.

An ideal time if we are not 99% certain this will stick would be next Tuesday Oct 23rd.  Happy to see this now if the confidence is high.  If we do land and backout, lets then wait until Oct 23rd before starting up again.

Comment 5

[Mark Cornmesser [:markco]]

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #4)
> :markco, thanks for checking- I think upgrading the worker would be fine-
> one thing to be careful is that we have our next uplift taking place next
> week and this week is the "pre-release", so if we have a lot of back and
> forth/downtime/shifting in numbers, it can be confusing.
> 
> An ideal time if we are not 99% certain this will stick would be next
> Tuesday Oct 23rd.  Happy to see this now if the confidence is high.  If we
> do land and backout, lets then wait until Oct 23rd before starting up again.

I am confident here. This is bringing Win 10 hardware up to the same version of generic-worker as all other platforms. If we hit any issues I will back out and then plan for Oct 23rd.