1496389 - Taskcluster emails for try pushes no longer contain the description in the summary

Status: NEW

(Firefox Build System :: Task Configuration, task)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Since recently the emails from Taskcluster when pushing new try builds have been changed. As such those show a summary like:

> Thank you for your try submission of 9b34cd477af88c4b69ebe8023cd68a2af453c1ca. It's the best!

I don't think that anyone can remember SHA entries for particular pushes. Why aren't we showing the description of the try commit anymore?

Can we please do that again? Right now it is impossible to differentiate various try builds in the inbox of my MUA.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Henrik, this is defined in `.taskcluster.yml` and can be changed there.  I think you can use `push.comment`, although that will be multi-line so you probably want to trim it down a little.

Comment 2

[Tom Prince [:tomprince]]

mozilla-taskcluster actually only provides the try syntax to the decision task (if there is any), and otherwise the comment is blank.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

We could maybe change that in mozilla-taskcluster :)

Comment 7

[Connor Sheehan [:sheehan]]

Judging by the number of duplicates on this bug, this was a much loved feature and we should restore it. As Tom mentioned in comment 2, the `push.comment` context variable only contains the commit message from the tip of the push (ie the try syntax commit). I doubt this is worth adding to the commit message as I'm sure there are people who regularly run the same jobs on try for their unrelated changes. Maybe it is worth doing as an MVP.

Dustin: would it be possible to add a new context variable to [0] (say `changesets`, or we could modify `push` perhaps) which would be an array of information about each changeset in the push? Then if the try syntax commit is say `changesets[0]`, we could add `changesets[1].comment` to the subject line of the commit message. If you have other ideas I would love to hear them as well.

I was also wondering if you knew where the code that injects [0] into JSON-e lives. The docs seem to indicate mozilla-taskcluster but I can't find it when I scan the repo.

[0] https://docs.taskcluster.net/docs/reference/integrations/mozilla-taskcluster/docs/taskcluster-yml#json-e-rendering

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

That sounds like it would be difficult to implement in JSON-e.  Also, we are planning to replace mozilla-taskcluster with a hook that listens for Pulse messages from hg, so we would only have available the information in the Pulse message (https://mozilla-version-control-tools.readthedocs.io/en/latest/hgmo/notifications.html).  If that field grew a "pushSummary" field or something of the sort, we could use that..

Probably a better fix is to do this notification in the decision task itself.  It has access to a repo checkout, so it can look directly at all of the commits and do whatever manipulations are necessary to find a nice summary.

Comment 9

[Botond Ballo [:botond]]

Any chance of getting this fixed? From time to time I need to find an old Try push, and it used to be very easy to do this by looking through my Try emails, and now it's next to impossible because all they have is SHAs...