1496426 - Use GCC atomic builtins for Linux x86/x86_64

Status: NEW

(NSPR :: NSPR, enhancement)

Description

[Daiki Ueno [:ueno]]

Attachment: nspr-x86-gcc-atomics.patch

For Linux x86{,_64}, the PR_Atomic* functions are implemented in assembly; that means that the linked binary can't benefit from the hardening by the compiler, such as CET:
https://software.intel.com/sites/default/files/managed/4d/2a/control-flow-enforcement-technology-preview.pdf

What about porting them to use the GCC primitives?

Comment 1

[Kai Engert [:KaiE:]]

What is the expected effect of the change? Do you anticipate a change in speed?

I suggest to execute a Firefox try build, include the "Talos" performance testing, with your suggested change, and compare the effect it has on performance.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.