1496461 - socorro deploy: 339

Status: RESOLVED FIXED

(Socorro :: Infra, task, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

We want to do a Socorro -prod deploy today tagged 339.

It consists of the following:

(current tag: 338 - 29c0125)
226eb26: bug 1463121: fix data migration script to work in prod (willkg)
94360f3: leverage globbing for a more concise run_tests_python3 file (lonnen)
f392186: replace last use of Queue lib with six.moves.queue (lonnen)
e4ceeac: remove unused optionfile library (lonnen)
46f88d4: inline the ALWAYS TRUE and inconsistently used do_quit_check variable (lonnen)
cc55464: remove is_infinite flag and logging message (lonnen)
6b712a0: Switch transaction executor to use reraise (lonnen)
57e9654: replace all use of imap with six.moves.map (lonnen)
2a1838e: replace .keys() with a six compat method in es index cleaner (lonnen)
136462c: replace .keys() with a six compat method in es integration test (lonnen)
bfc0b25: replace iteritems with a six compat method in rmq connection pool (lonnen)
59e2bb7: linter fixups (lonnen)
4ba4b86: remove unused import (lonnen)
1436338: disable unfixed python3 tests, no impact on python 2 (lonnen)
f5f3d8d: Fixed cache tests, tweaked some code, sorted test files (willkg)
ea68b62: bug 1463121: Add row counts for non-pg tables to debug view (willkg)
9caaef5: bug 1463121: fix debug view db table counts to work in stage (willkg)
(next tag: 339 - 300824d)

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

226eb26: bug 1463121: fix data migration script to work in prod (willkg)

This is in prod and we ran it and everything is fine.

94360f3: leverage globbing for a more concise run_tests_python3 file (lonnen)
f392186: replace last use of Queue lib with six.moves.queue (lonnen)
e4ceeac: remove unused optionfile library (lonnen)
46f88d4: inline the ALWAYS TRUE and inconsistently used do_quit_check variable (lonnen)
cc55464: remove is_infinite flag and logging message (lonnen)
6b712a0: Switch transaction executor to use reraise (lonnen)
57e9654: replace all use of imap with six.moves.map (lonnen)
2a1838e: replace .keys() with a six compat method in es index cleaner (lonnen)
136462c: replace .keys() with a six compat method in es integration test (lonnen)
bfc0b25: replace iteritems with a six compat method in rmq connection pool (lonnen)
59e2bb7: linter fixups (lonnen)
4ba4b86: remove unused import (lonnen)
1436338: disable unfixed python3 tests, no impact on python 2 (lonnen)
f5f3d8d: Fixed cache tests, tweaked some code, sorted test files (willkg)

These have been on stage for a few days and they seem fine.

ea68b62: bug 1463121: Add row counts for non-pg tables to debug view (willkg)
9caaef5: bug 1463121: fix debug view db table counts to work in stage (willkg)

I verified that this is working on stage and used it to verify that signatures are being updated in both the "signatures" and "crashstats_signature" tables.

We're good to go here.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

$ git show 339
tag 339
Tagger: Will Kahn-Greene <[e-mail]>
Date:   Thu Oct 4 11:48:25 2018 -0400

Tag 339 for deploy
-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEzY3I6/E2Vh8o9nPoGL3RpvBm7BEFAlu2NkwACgkQGL3RpvBm
7BFFfAf/UvNt6Oun4BIcdXJbyLOowdjBqTYiAchjgbqmrwJ+t2xGmSBkwp5cDDxK
zTi5pHRph2iLOTQoLJ1N7tPU7umrPEHnMeloJXTe3Q1alJ/ckDhURZKf/OdsJ/uV
RyYI4mDPgJqMJnUVQ4vCwGuhTN0RqWw/hA5nFTivPnQzeWbeoCtWAyGC/DGITnxO
QKNngKZPSqsx2pijoYg9o97yMZH18tBA/6n3n8I13aZc+wnjbC39b9UWsjSJ1pzi
3Ab1D/EEaCxDAkKz3On8Gea+GE6GCi4n2YY7G6Zsqe3AKVZGAPw11OJd73bIpyep
0vh1jkzbSzx0C/mbBLfwBzbEcEZLHw==
=0xbp
-----END PGP SIGNATURE-----

commit 300824d427247613f9e4b151bcd5a6f7cbb14136 (HEAD -> master, tag: 339, official/master)
Merge: 7da41ff29 9caaef5d2
Author: Will Kahn-Greene <[e-mail]>
Date:   Thu Oct 4 10:51:38 2018 -0400

    Merge pull request #4632 from willkg/1463121-fix-debug-view
    
    bug 1463121: fix debug view db table counts to work in stage

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Everything seems fine. Marking as FIXED.