1496518 - remove some unneeded includes in mailnews/

Status: RESOLVED FIXED

(MailNews Core :: Backend, enhancement, P5)

Description

[:aceman]

+++ This bug was initially created as a clone of Bug #1460049 +++

There are some includes in the /mailnews c++ files (.h, .cpp, .mm) that seem unneeded, the code does not use any identifier from the included file.
I've made a quick script to identify where nsI* objects aren't used in the file, but nsI*.h file is included. Many of them are unneeded.
Cleaning up the needless includes may speed up compiling by a tiny bit ;)

I will attach several patches into this bug that cover the individual code directories under /mailnews.
There is no priority to check them in after review.
Jorg, you can use the patches for check-ins when needed, similar to bug 1399756.

Comment 1

[:aceman]

Attachment: 1496518.patch - misc

Some more possibilities detected in the directories I already passed through.
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a972754fffc952f38395b30def4952ba93af7e3c

Some directories still remaining.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9014896 [details] [diff] [review]
1496518.patch - misc

Wow, a lot of removals. Look great and still compiles ;-)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4aa20359173f
remove some unneeded includes in mailnews/. r=jorgk

Comment 4

[:aceman]

Comment on attachment 9014896 [details] [diff] [review]
1496518.patch - misc

Review of attachment 9014896 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/mime/src/mimecms.h
@@ +7,5 @@
>  #define _MIMECMS_H_
>  
>  #include "mimecryp.h"
>  
> +class nsICMSMessage; // for function arguments in mimecms.h

This should be mimecms.c .

Comment 5

[:aceman]

Attachment: 1496518 - nsIAuthModule

Comment 6

[:aceman]

Attachment: 1496518 - nsIAuthModule v1.1

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9021369 [details] [diff] [review]
1496518 - nsIAuthModule v1.1

OK, thanks. Let's not set checkin-needed. I'll remember it.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ba5473b1f7dd
fix inclusions of nsIAuthModule. r=jorgk

Comment 9

[:aceman]

Attachment: 1496518-3.patch - nsMsgFolderFlags

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=2c959b7a215ae9ad9806235e90be80a4d6be5713

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4c2c4bf909f7
remove unused inclusions of nsMsgFolderFlags.h. r=jorgk DONTBUILD