Closed
Bug 1496518
Opened 3 years ago
Closed 2 years ago
remove some unneeded includes in mailnews/
Categories
(MailNews Core :: Backend, enhancement, P5)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 64.0
People
(Reporter: aceman, Assigned: aceman)
References
Details
(Whiteboard: only check in when nothing else can be checked in and you want to invoke a new build on trunk)
Attachments
(3 files, 1 obsolete file)
28.98 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
3.02 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
2.20 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1460049 +++ There are some includes in the /mailnews c++ files (.h, .cpp, .mm) that seem unneeded, the code does not use any identifier from the included file. I've made a quick script to identify where nsI* objects aren't used in the file, but nsI*.h file is included. Many of them are unneeded. Cleaning up the needless includes may speed up compiling by a tiny bit ;) I will attach several patches into this bug that cover the individual code directories under /mailnews. There is no priority to check them in after review. Jorg, you can use the patches for check-ins when needed, similar to bug 1399756.
Some more possibilities detected in the directories I already passed through. https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a972754fffc952f38395b30def4952ba93af7e3c Some directories still remaining.
Attachment #9014896 -
Flags: review?(jorgk)
Comment 2•3 years ago
|
||
Comment on attachment 9014896 [details] [diff] [review] 1496518.patch - misc Wow, a lot of removals. Look great and still compiles ;-)
Attachment #9014896 -
Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/4aa20359173f remove some unneeded includes in mailnews/. r=jorgk
Comment on attachment 9014896 [details] [diff] [review] 1496518.patch - misc Review of attachment 9014896 [details] [diff] [review]: ----------------------------------------------------------------- ::: mailnews/mime/src/mimecms.h @@ +7,5 @@ > #define _MIMECMS_H_ > > #include "mimecryp.h" > > +class nsICMSMessage; // for function arguments in mimecms.h This should be mimecms.c .
Attachment #9021368 -
Flags: review?(jorgk)
Attachment #9021368 -
Attachment is obsolete: true
Attachment #9021368 -
Flags: review?(jorgk)
Attachment #9021369 -
Flags: review?(jorgk)
Comment 7•3 years ago
|
||
Comment on attachment 9021369 [details] [diff] [review] 1496518 - nsIAuthModule v1.1 OK, thanks. Let's not set checkin-needed. I'll remember it.
Attachment #9021369 -
Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/ba5473b1f7dd fix inclusions of nsIAuthModule. r=jorgk
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=2c959b7a215ae9ad9806235e90be80a4d6be5713
Attachment #9021673 -
Flags: review?(jorgk)
Updated•3 years ago
|
Attachment #9021673 -
Flags: review?(jorgk) → review+
Comment 10•3 years ago
|
||
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/4c2c4bf909f7 remove unused inclusions of nsMsgFolderFlags.h. r=jorgk DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•