Prio-encoded Telemetry should use build ID for its batch ID

RESOLVED FIXED in Firefox 64

Status

()

enhancement
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: rhelmer, Assigned: rhelmer)

Tracking

unspecified
mozilla64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

9 months ago
Per https://searchfox.org/mozilla-central/rev/924e3d96d81a40d2f0eec1db5f74fc6594337128/third_party/prio/include/mprio.h#80-84 we need to share the batch ID between the client and server.

When I added Prio-encoding to Telemetry, I had thought `Policy.now()` https://searchfox.org/mozilla-central/rev/924e3d96d81a40d2f0eec1db5f74fc6594337128/toolkit/components/telemetry/pings/TelemetrySession.jsm#1985 was the current date string, but looking now it's a datestring https://searchfox.org/mozilla-central/rev/924e3d96d81a40d2f0eec1db5f74fc6594337128/toolkit/components/telemetry/pings/TelemetrySession.jsm#121

However after discussing w/ amiyaguchi, I think for the purposes of the pilot project it'd be simplest on the server-side to just use the build ID here.

Comment 2

9 months ago
Pushed by rhelmer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3e1d1b6a529e
Use build ID as the batchID for prio-encoded telemetry r=chutten

Comment 3

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3e1d1b6a529e
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
See Also: → 1497116
You need to log in before you can comment on or make changes to this bug.