1496572 - Intermittent devtools/client/inspector/test/browser_inspector_highlighter-eyedropper-xul.js | The button is enabled in the toolbar -

Status: NEW

(DevTools :: Inspector, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: rgurzau [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=203474745&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/Vlloy40-QYiSHx0PKFCZOw/runs/0/artifacts/public/logs/live_backing.log

12:49:25     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_highlighter-eyedropper-xul.js | The button is disabled in the color picker - 
12:49:25     INFO - Navigate to a HTML document
12:49:25     INFO - Navigating to: data:text/html;charset=utf-8,<h1 style='color:red'>HTML test page</h1>
12:49:25     INFO - Waiting for markup view to load after navigation.
12:49:25     INFO - Buffered messages logged at 12:49:25
12:49:25     INFO - Waiting for new root.
12:49:25     INFO - Waiting for inspector to update after new-root event.
12:49:25     INFO - Check the inspector toolbar in HTML document
12:49:25     INFO - Buffered messages finished
12:49:25     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/test/browser_inspector_highlighter-eyedropper-xul.js | The button is enabled in the toolbar - 
12:49:25     INFO - Stack trace:
12:49:25     INFO - chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_highlighter-eyedropper-xul.js:null:42
12:49:25     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1093
12:49:25     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1084
12:49:25     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:986
12:49:25     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
12:49:25     INFO - Check the color picker in HTML document

Comment 1

[Cristian Brindusan [:cbrindusan]]

I've b/r from 0044b2201cb7 to 52f118be7c58 and seems that the culprit is changeset dd9ecb747f9d:

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&searchStr=a4e4cb5ec01720ec1898c445c4f09af2d0159047&tochange=0044b2201cb71f3c2d3c5aa6dda040f693847b79&fromchange=52f118be7c585e6b4012f42463977fdd220a5eb6&selectedJob=203801120
@Joel, can you please take a look?

Comment 2

[Joel Maher ( :jmaher ) (UTC-4)]

great work :cbrindusan, I agree that bug 1494162 is the root cause, :gl, can you look at this to see why this intermittent has started failing so frequently after your patch?

Comment 3

[Patrick Brosset <:pbro>]

I'll let Gabriel investigate further when he's back, but my impression is that this is due to the call to this.setupToolbar() inside inspector.js's onNewRoot callback which is not async.
So, it doesn't wait for setupToolbar to resolve before proceeding, which means there's a race condition whereby sometimes, the eye-dropper icon does not have time to be updated before the rest of the test runs.

Comment 4

[Intermittent Failures Robot]

22 failures in 2708 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 10
* mozilla-inbound: 9
* try: 1
* mozilla-central: 2

Platform breakdown:
* windows7-32: 2
* osx-10-10: 13
* linux64-ccov: 1
* windows10-64: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496572&startday=2018-10-01&endday=2018-10-07&tree=all

Comment 5

[Intermittent Failures Robot]

15 failures in 537 pushes (0.028 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-central: 3
* autoland: 8
* mozilla-inbound: 4

Platform breakdown:
* windows7-32: 1
* windows10-64: 5
* osx-10-10: 8
* linux32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496572&startday=2018-10-09&endday=2018-10-09&tree=all

Comment 6

[Intermittent Failures Robot]

36 failures in 552 pushes (0.065 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-central: 5
* mozilla-inbound: 21
* autoland: 10

Platform breakdown:
* osx-10-10: 8
* windows7-32-msvc: 1
* linux64-ccov: 1
* windows7-32: 6
* linux32: 3
* linux64: 11
* windows10-64: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496572&startday=2018-10-10&endday=2018-10-10&tree=all

Comment 7

[Intermittent Failures Robot]

67 failures in 537 pushes (0.125 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. ** 

Repository breakdown:
* mozilla-central: 12
* autoland: 35
* mozilla-inbound: 15
* try: 5

Platform breakdown:
* windows10-64-msvc: 1
* windows10-64: 7
* osx-10-10: 7
* windows7-32: 13
* linux32-nightly: 1
* windows7-32-msvc: 3
* linux64: 24
* linux64-ccov: 1
* linux32: 10

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496572&startday=2018-10-11&endday=2018-10-11&tree=all

Comment 8

[Intermittent Failures Robot]

73 failures in 515 pushes (0.142 failures/push) were associated with this bug yesterday.

Repository breakdown:
* try: 2
* mozilla-central: 8
* mozilla-inbound: 23
* autoland: 40

Platform breakdown:
* linux64: 19
* windows10-64: 14
* windows10-64-ccov: 2
* linux64-nightly: 1
* windows7-32: 14
* linux32: 13
* linux64-ccov: 1
* osx-10-10: 8
* windows10-64-msvc: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496572&startday=2018-10-12&endday=2018-10-12&tree=all

Comment 9

[Tiberius Oros[:tiberius_oros]]

Attachment: disable_bug1496572.patch

Comment 10

[Joel Maher ( :jmaher ) (UTC-4)]

Comment on attachment 9016939 [details] [diff] [review]
disable_bug1496572.patch

Review of attachment 9016939 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/inspector/test/browser.ini
@@ +101,4 @@
>  [browser_inspector_highlighter-eyedropper-label.js]
>  [browser_inspector_highlighter-eyedropper-show-hide.js]
>  [browser_inspector_highlighter-eyedropper-xul.js]
> +skip-if = (os == 'win') || (os == 'linux') || (os == 'mac') # Bug 1496572

this should be:
skip-if = true

Comment 11

[Tiberius Oros[:tiberius_oros]]

Attachment: skip_bug_1496572.patch

Comment 12

[Gabriel [:gl] (ΦωΦ)]

Attachment: 1496572.patch [1.0]

Comment 13

[Intermittent Failures Robot]

26 failures in 147 pushes (0.177 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-central: 5
* autoland: 10
* mozilla-inbound: 8
* try: 3

Platform breakdown:
* linux64: 6
* linux32-nightly: 1
* windows7-32: 4
* linux64-ccov: 1
* linux32: 7
* windows10-64: 3
* linux64-nightly: 1
* osx-10-10: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496572&startday=2018-10-13&endday=2018-10-13&tree=all

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4afcdb551984
Fix intermittent devtools/client/inspector/test/browser_inspector_highlighter-eyedropper-xul.js by adding a new emitted event for the inspector toolbar update. r=pbro

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4afcdb551984

Comment 16

[Intermittent Failures Robot]

255 failures in 2740 pushes (0.093 failures/push) were associated with this bug in the last 7 days.

This is the #3 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. ** 

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. ** 

Repository breakdown:
* try: 20
* autoland: 116
* mozilla-inbound: 80
* mozilla-central: 39

Platform breakdown:
* osx-10-10: 47
* windows10-64-msvc: 2
* linux64: 67
* linux64-devedition: 1
* windows10-64-ccov: 4
* windows7-32-msvc: 4
* windows7-32-nightly: 1
* linux32-nightly: 2
* windows7-32: 41
* linux32: 40
* linux64-nightly: 2
* linux64-ccov: 4
* windows10-64: 40

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496572&startday=2018-10-08&endday=2018-10-14&tree=all

Comment 17

[Intermittent Failures Robot]

4 failures in 2759 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 2
* try: 2

Platform breakdown:
* windows10-64: 1
* linux32: 1
* windows7-32: 1
* linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496572&startday=2018-10-15&endday=2018-10-21&tree=all

Comment 18

[Intermittent Failures Robot]

1 failures in 2658 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496572&startday=2019-02-04&endday=2019-02-10&tree=all

Comment 19

[Gabriel [:gl] (ΦωΦ)]

Unassigning myself since i have been inactive on this bug.