Open
Bug 1496572
Opened 2 years ago
Updated 2 years ago
Intermittent devtools/client/inspector/test/browser_inspector_highlighter-eyedropper-xul.js | The button is enabled in the toolbar -
Categories
(DevTools :: Inspector, defect, P5)
DevTools
Inspector
Tracking
(Not tracked)
NEW
People
(Reporter: intermittent-bug-filer, Unassigned)
Details
(Keywords: intermittent-failure, leave-open, Whiteboard: [stockwell disabled])
Attachments
(2 files, 1 obsolete file)
784 bytes,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
2.30 KB,
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
Filed by: rgurzau [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=203474745&repo=mozilla-inbound https://queue.taskcluster.net/v1/task/Vlloy40-QYiSHx0PKFCZOw/runs/0/artifacts/public/logs/live_backing.log 12:49:25 INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_highlighter-eyedropper-xul.js | The button is disabled in the color picker - 12:49:25 INFO - Navigate to a HTML document 12:49:25 INFO - Navigating to: data:text/html;charset=utf-8,<h1 style='color:red'>HTML test page</h1> 12:49:25 INFO - Waiting for markup view to load after navigation. 12:49:25 INFO - Buffered messages logged at 12:49:25 12:49:25 INFO - Waiting for new root. 12:49:25 INFO - Waiting for inspector to update after new-root event. 12:49:25 INFO - Check the inspector toolbar in HTML document 12:49:25 INFO - Buffered messages finished 12:49:25 INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/test/browser_inspector_highlighter-eyedropper-xul.js | The button is enabled in the toolbar - 12:49:25 INFO - Stack trace: 12:49:25 INFO - chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_highlighter-eyedropper-xul.js:null:42 12:49:25 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1093 12:49:25 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1084 12:49:25 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:986 12:49:25 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795 12:49:25 INFO - Check the color picker in HTML document
Comment 1•2 years ago
|
||
I've b/r from 0044b2201cb7 to 52f118be7c58 and seems that the culprit is changeset dd9ecb747f9d: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&searchStr=a4e4cb5ec01720ec1898c445c4f09af2d0159047&tochange=0044b2201cb71f3c2d3c5aa6dda040f693847b79&fromchange=52f118be7c585e6b4012f42463977fdd220a5eb6&selectedJob=203801120 @Joel, can you please take a look?
Flags: needinfo?(jmaher)
Comment 2•2 years ago
|
||
great work :cbrindusan, I agree that bug 1494162 is the root cause, :gl, can you look at this to see why this intermittent has started failing so frequently after your patch?
Flags: needinfo?(jmaher) → needinfo?(gl)
Comment 3•2 years ago
|
||
I'll let Gabriel investigate further when he's back, but my impression is that this is due to the call to this.setupToolbar() inside inspector.js's onNewRoot callback which is not async. So, it doesn't wait for setupToolbar to resolve before proceeding, which means there's a race condition whereby sometimes, the eye-dropper icon does not have time to be updated before the rest of the test runs.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•2 years ago
|
Assignee: nobody → gl
Status: NEW → ASSIGNED
Flags: needinfo?(gl)
Comment hidden (Intermittent Failures Robot) |
Comment 9•2 years ago
|
||
Attachment #9016939 -
Flags: review?(jmaher)
Comment 10•2 years ago
|
||
Comment on attachment 9016939 [details] [diff] [review] disable_bug1496572.patch Review of attachment 9016939 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/client/inspector/test/browser.ini @@ +101,4 @@ > [browser_inspector_highlighter-eyedropper-label.js] > [browser_inspector_highlighter-eyedropper-show-hide.js] > [browser_inspector_highlighter-eyedropper-xul.js] > +skip-if = (os == 'win') || (os == 'linux') || (os == 'mac') # Bug 1496572 this should be: skip-if = true
Attachment #9016939 -
Flags: review?(jmaher) → review-
Comment 11•2 years ago
|
||
Attachment #9016939 -
Attachment is obsolete: true
Attachment #9016947 -
Flags: review?(jmaher)
Updated•2 years ago
|
Attachment #9016947 -
Flags: review?(jmaher) → review+
Updated•2 years ago
|
Keywords: checkin-needed,
leave-open
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Comment 12•2 years ago
|
||
Attachment #9016949 -
Flags: review?(pbrosset)
Comment hidden (Intermittent Failures Robot) |
Updated•2 years ago
|
Attachment #9016949 -
Flags: review?(pbrosset) → review+
Comment 14•2 years ago
|
||
Pushed by rgurzau@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4afcdb551984 Fix intermittent devtools/client/inspector/test/browser_inspector_highlighter-eyedropper-xul.js by adding a new emitted event for the inspector toolbar update. r=pbro
Keywords: checkin-needed
Comment 15•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4afcdb551984
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 19•2 years ago
|
||
Unassigning myself since i have been inactive on this bug.
Assignee: gl → nobody
Status: ASSIGNED → NEW
You need to log in
before you can comment on or make changes to this bug.
Description
•