1496578 - convert nsDefaultURIFixup to js and rename it to make it clear it's the only one

Status: RESOLVED FIXED

(Core :: DOM: Navigation, enhancement, P2)

Description

[Nika Layzell [:nika] (ooo, ni? for response)]

The only implementation of `nsIURIFixup` currently is `nsDefaultURIFixup`. It would make sense to rename `nsDefaultURIFixup` to `nsURIFixup` and mark `nsIURIFixup` as builtinclass to formalize that, as the current name misleadingly implies there are multiple implementations of the interface.

Comment 1

[:Gijs (he/him)]

(In reply to :Nika Layzell from comment #0)
> The only implementation of `nsIURIFixup` currently is `nsDefaultURIFixup`.
> It would make sense to rename `nsDefaultURIFixup` to `nsURIFixup` and mark
> `nsIURIFixup` as builtinclass to formalize that, as the current name
> misleadingly implies there are multiple implementations of the interface.

I'm fine with a rename. However, I think we should eventually move the implementation here to JS, and stop docshell from doing fixup on its own. `builtinclass` in the IDL goes in the other direction. I guess we can remove it again if we ever get around to moving this to JS...

Comment 2

[Marco Bonardo [:mak]]

I don't know where I'll end up, but I'm progressing with the conversion.

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1496578 - convert nsDefaultURIFixup to URIFixup.jsm.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b86e8f2cc5db
convert nsDefaultURIFixup to URIFixup.jsm. r=Gijs,farre

Comment 5

[Razvan Maries]

Backed out for build bustages.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=296693755&resultStatus=testfailed%2Cbusted%2Cexception&revision=b86e8f2cc5dbaa61d4a8d5667903d2443da88e41

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296693755&repo=autoland&lineNumber=33609

Backout: https://hg.mozilla.org/integration/autoland/rev/f10b4a4ea1d8f331445c273f77c1f8ac3867c1ef

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2f426661f29
convert nsDefaultURIFixup to URIFixup.jsm. r=Gijs,farre

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b2f426661f29