Closed
Bug 1496578
Opened 3 years ago
Closed 1 year ago
convert nsDefaultURIFixup to js and rename it to make it clear it's the only one
Categories
(Core :: DOM: Navigation, enhancement, P2)
Core
DOM: Navigation
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: nika, Assigned: mak)
References
Details
Attachments
(1 file)
The only implementation of `nsIURIFixup` currently is `nsDefaultURIFixup`. It would make sense to rename `nsDefaultURIFixup` to `nsURIFixup` and mark `nsIURIFixup` as builtinclass to formalize that, as the current name misleadingly implies there are multiple implementations of the interface.
|
||
Comment 1•3 years ago
|
||
(In reply to :Nika Layzell from comment #0) > The only implementation of `nsIURIFixup` currently is `nsDefaultURIFixup`. > It would make sense to rename `nsDefaultURIFixup` to `nsURIFixup` and mark > `nsIURIFixup` as builtinclass to formalize that, as the current name > misleadingly implies there are multiple implementations of the interface. I'm fine with a rename. However, I think we should eventually move the implementation here to JS, and stop docshell from doing fixup on its own. `builtinclass` in the IDL goes in the other direction. I guess we can remove it again if we ever get around to moving this to JS...
|
Assignee | |
Updated•3 years ago
|
Priority: -- → P3
|
|
Assignee | |
Updated•2 years ago
|
Component: Address Bar → Document Navigation
Product: Firefox → Core
|
|
Assignee | |
Updated•1 year ago
|
Summary: Rename nsDefaultURIFixup to make it clear it's the only one → convert nsDefaultURIFixup to js and rename it to make it clear it's the only one
|
|
Assignee | |
Comment 2•1 year ago
|
||
I don't know where I'll end up, but I'm progressing with the conversion.
Assignee: nobody → mak
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•1 year ago
|
Iteration: --- → 76.1 - Mar 9 - Mar 22
|
|
Assignee | |
Comment 3•1 year ago
|
||
|
|
Assignee | |
Updated•1 year ago
|
Points: --- → 5
|
||
Updated•1 year ago
|
Attachment #9132883 -
Attachment description: Bug 1496578 - convert nsDefaultURIFixup to js and rename it → * Bug 1496578 - convert nsDefaultURIFixup to js and rename it
|
|
||
Updated•1 year ago
|
Attachment #9132883 -
Attachment description: * Bug 1496578 - convert nsDefaultURIFixup to js and rename it → Bug 1496578 - convert nsDefaultURIFixup to js and rename it.
|
|
Assignee | |
Updated•1 year ago
|
Priority: P3 → P2
|
|
||
Updated•1 year ago
|
Attachment #9132883 -
Attachment description: Bug 1496578 - convert nsDefaultURIFixup to js and rename it. → Bug 1496578 - convert nsDefaultURIFixup to URIFixup.jsm.
|
||
Updated•1 year ago
|
Iteration: 76.1 - Mar 9 - Mar 22 → 76.2 - Mar 23 - Apr 5
|
|
Assignee | |
Updated•1 year ago
|
Iteration: 76.2 - Mar 23 - Apr 5 → 77.2 - Apr 20 - May 3
|
|
Assignee | |
Updated•1 year ago
|
Iteration: 77.2 - Apr 20 - May 3 → 77.1 - Apr 6 - Apr 19
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/b86e8f2cc5db convert nsDefaultURIFixup to URIFixup.jsm. r=Gijs,farre
|
||
Comment 5•1 year ago
|
||
Backed out for build bustages.
Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=296693755&resultStatus=testfailed%2Cbusted%2Cexception&revision=b86e8f2cc5dbaa61d4a8d5667903d2443da88e41
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296693755&repo=autoland&lineNumber=33609
Backout: https://hg.mozilla.org/integration/autoland/rev/f10b4a4ea1d8f331445c273f77c1f8ac3867c1ef
Flags: needinfo?(mak)
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/b2f426661f29 convert nsDefaultURIFixup to URIFixup.jsm. r=Gijs,farre
|
||
Comment 7•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
|
|
Assignee | |
Updated•1 year ago
|
Flags: needinfo?(mak)
You need to log in
before you can comment on or make changes to this bug.
Description
•