Closed
Bug 1496623
Opened 6 years ago
Closed 6 years ago
GeckoProfilerThread::installed() is misleading
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: pbone, Assigned: pbone)
Details
Attachments
(1 file, 1 obsolete file)
|
2.88 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
See Bug 1494278 Comment 17 This does not say whether the addon is installed, but whether the profiling infrastructure is installed in the process.
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9014656 [details] [diff] [review] Bug 1496623 - Rename and comment GeckoProfilerThread::installed() Review of attachment 9014656 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/public/ProfilingStack.h @@ +481,5 @@ > + /* > + * True if the profiler infrastructure is setup. (should be true except > + * during early startup or late shutdown in builds that include profiler > + * support. Unrelated to the presence of the gecko profiler addon. > + */ This comment needs reworking: - No upper case letter at start of "should" sentence. - No closing ')'. - Capitalize "Gecko Profiler". - The "except" condition is confusing -- "in builds that include profiler support" should probably be moved before the "except".
Attachment #9014656 -
Flags: review?(n.nethercote) → feedback+
|
|
Assignee | |
Comment 3•6 years ago
|
||
Attachment #9014656 -
Attachment is obsolete: true
Attachment #9015169 -
Flags: review?(n.nethercote)
|
|
||
Updated•6 years ago
|
Attachment #9015169 -
Flags: review?(n.nethercote) → review+
Pushed by pbone@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/470dd43efaa6 Rename and comment GeckoProfilerThread::installed() r=njn
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/470dd43efaa6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•