GeckoProfilerThread::installed() is misleading

RESOLVED FIXED in Firefox 64

Status

()

enhancement
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: pbone, Assigned: pbone)

Tracking

unspecified
mozilla64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

8 months ago
See Bug 1494278 Comment 17 This does not say whether the addon is installed, but whether the profiling infrastructure is installed in the process.
Assignee

Comment 1

8 months ago
Assignee: nobody → pbone
Status: NEW → ASSIGNED
Attachment #9014656 - Flags: review?(n.nethercote)
Comment on attachment 9014656 [details] [diff] [review]
Bug 1496623 - Rename and comment GeckoProfilerThread::installed()

Review of attachment 9014656 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/public/ProfilingStack.h
@@ +481,5 @@
> +    /*
> +     * True if the profiler infrastructure is setup.  (should be true except
> +     * during early startup or late shutdown in builds that include profiler
> +     * support.  Unrelated to the presence of the gecko profiler addon.
> +     */

This comment needs reworking:
- No upper case letter at start of "should" sentence.
- No closing ')'.
- Capitalize "Gecko Profiler".
- The "except" condition is confusing -- "in builds that include profiler support" should probably be moved before the "except".
Attachment #9014656 - Flags: review?(n.nethercote) → feedback+
Assignee

Comment 3

8 months ago
Attachment #9014656 - Attachment is obsolete: true
Attachment #9015169 - Flags: review?(n.nethercote)
Attachment #9015169 - Flags: review?(n.nethercote) → review+

Comment 4

7 months ago
Pushed by pbone@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/470dd43efaa6
Rename and comment GeckoProfilerThread::installed() r=njn

Comment 5

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/470dd43efaa6
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.