Closed Bug 1496705 Opened 11 months ago Closed 11 months ago

UrlbarInput.jsm: Rename _inOverflow to _overflowing

Categories

(Firefox :: Address Bar, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: dao, Assigned: abdelrahman, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

_inOverflow is kind of a weird name. As opposed to urlbarBindings.xml, browser/components/urlbar/UrlbarInput.jsm doesn't depend on autocomplete.xml, so let's rename _inOverflow to _overflowing here.
Assignee: nobody → a.ahmed1026
Status: NEW → ASSIGNED
Attachment #9015172 - Flags: review?(dao+bmo)
Attachment #9015172 - Attachment description: rename-inOverflow → v1 - rename-inOverflow
Attachment #9015172 - Attachment is patch: true
Attachment #9015172 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 9015172 [details] [diff] [review]
v1 - rename-inOverflow

Looks good, thanks!
Attachment #9015172 - Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/113ba8a072a6
Rename _inOverflow to _overflowing. r=dao
https://hg.mozilla.org/mozilla-central/rev/113ba8a072a6
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.