Closed
Bug 1496705
Opened 6 years ago
Closed 6 years ago
UrlbarInput.jsm: Rename _inOverflow to _overflowing
Categories
(Firefox :: Address Bar, enhancement, P3)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: dao, Assigned: abdelrahman, Mentored)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file)
|
1.63 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
_inOverflow is kind of a weird name. As opposed to urlbarBindings.xml, browser/components/urlbar/UrlbarInput.jsm doesn't depend on autocomplete.xml, so let's rename _inOverflow to _overflowing here.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → a.ahmed1026
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9015172 -
Flags: review?(dao+bmo)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9015172 -
Attachment description: rename-inOverflow → v1 - rename-inOverflow
Attachment #9015172 -
Attachment is patch: true
Attachment #9015172 -
Attachment mime type: application/octet-stream → text/plain
|
Reporter | |
Comment 2•6 years ago
|
||
Comment on attachment 9015172 [details] [diff] [review] v1 - rename-inOverflow Looks good, thanks!
Attachment #9015172 -
Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/113ba8a072a6 Rename _inOverflow to _overflowing. r=dao
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/113ba8a072a6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in
before you can comment on or make changes to this bug.
Description
•