1496718 - Stop clobbering gURLBar when exiting customize mode

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

This code assumes that the location bar might have been removed or re-added when exiting customize mode, but the location bar hasn't been removable for some time.

Comment 1

[:Gijs (he/him)]

Comment on attachment 9014747 [details] [diff] [review]
patch

Review of attachment 9014747 [details] [diff] [review]:
-----------------------------------------------------------------

It still gets wrapped into a toolbarpaletteitem, so I'd expect the binding and so on to get destroyed and recreated, so I would expect us to still need the iconbox bit. Did you test that part? If so, any idea why we no longer need to do that?

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 9014747 [details] [diff] [review]
patch

(In reply to :Gijs (he/him) from comment #1)
> Comment on attachment 9014747 [details] [diff] [review]
> patch
> 
> Review of attachment 9014747 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> It still gets wrapped into a toolbarpaletteitem, so I'd expect the binding
> and so on to get destroyed and recreated, so I would expect us to still need
> the iconbox bit. Did you test that part? If so, any idea why we no longer
> need to do that?

I tested it and it works just fine from what I can tell. These nodes aren't anonymous, so moving them around doesn't invalidate those references.

Comment 3

[:Gijs (he/him)]

Comment on attachment 9014747 [details] [diff] [review]
patch

Review of attachment 9014747 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-customization.js
@@ +47,1 @@
>        if (AppConstants.platform != "macosx")

Nit: please merge these 2 conditions.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/821354ee31d9
Stop clobbering gURLBar when exiting customize mode. r=gijs

Comment 5

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/821354ee31d9