Closed
Bug 1496722
Opened 2 years ago
Closed 2 years ago
Make nsIDocShellTreeItem.itemType read-only
Categories
(Core :: DOM: Navigation, enhancement, P2)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: farre, Assigned: farre)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → afarre
Blocks: browsingcontext
|
|
Assignee | |
Comment 1•2 years ago
|
||
The reason for making itemType read-only for nsDocShell is that it isn't expected that it should change once it has been created[1], which is now more easily accomplished after bug 1480198. [1] https://searchfox.org/mozilla-central/source/docshell/base/nsDocShell.h#1030-1031
Depends on: 1480198
|
|
Assignee | |
Comment 2•2 years ago
|
||
Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=274801887ec4b2a53702a63128b63464d77ff1dd&group_state=expanded
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
||
Updated•2 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
|
|
Assignee | |
Comment 4•2 years ago
|
||
Again, try looks good https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6d153e77559a75dc15c32bd7b8b5a923427e811&group_state=expanded
|
||
Updated•2 years ago
|
Attachment #9014847 -
Attachment description: Bug 1496722 - Make nsIDocShellTreeItem.itemType readonly → Bug 1496722 - Make nsIDocShellTreeItem.itemType readonly.
Pushed by afarre@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2c428c8fc568 Make nsIDocShellTreeItem.itemType readonly. r=peterv
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2c428c8fc568
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•