Make nsIDocShellTreeItem.itemType read-only

RESOLVED FIXED in Firefox 65

Status

()

P2
normal
RESOLVED FIXED
5 months ago
3 months ago

People

(Reporter: farre, Assigned: farre)

Tracking

(Blocks: 1 bug)

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

5 months ago
Assignee: nobody → afarre
Blocks: 1437994
(Assignee)

Comment 1

4 months ago
The reason for making itemType read-only for nsDocShell is that it isn't expected that it should change once it has been created[1], which is now more easily accomplished after bug 1480198.

[1] https://searchfox.org/mozilla-central/source/docshell/base/nsDocShell.h#1030-1031
Depends on: 1480198
(Assignee)

Comment 3

4 months ago
Created attachment 9014847 [details]
Bug 1496722 - Make nsIDocShellTreeItem.itemType readonly.
Status: NEW → ASSIGNED
Priority: -- → P2
Attachment #9014847 - Attachment description: Bug 1496722 - Make nsIDocShellTreeItem.itemType readonly → Bug 1496722 - Make nsIDocShellTreeItem.itemType readonly.

Comment 5

3 months ago
Pushed by afarre@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c428c8fc568
Make nsIDocShellTreeItem.itemType readonly. r=peterv

Comment 6

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2c428c8fc568
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.