Make nsIDocShellTreeItem.itemType read-only

RESOLVED FIXED in Firefox 65

Status

()

Product:
Core
Component:
Document Navigation
Type:
enhancement
Importance:
P2
normal
Status:
RESOLVED FIXED
Opened:
9 months ago
Updated:
8 months ago

People

(Reporter: farre, Assigned: farre)

Tracking

(Blocks 1 bug)

Version:
unspecified
Target:
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

Bug 1496722 - Make nsIDocShellTreeItem.itemType readonly.
46 bytes, text/x-phabricator-request
Details | Review
Assignee

Description

•
9 months ago 
No description provided.
 Assignee

Updated

•
9 months ago
Assignee: nobody → afarre
Blocks: browsingcontext
 Assignee

Comment 1

•
9 months ago 
The reason for making itemType read-only for nsDocShell is that it isn't expected that it should change once it has been created[1], which is now more easily accomplished after bug 1480198.

[1] https://searchfox.org/mozilla-central/source/docshell/base/nsDocShell.h#1030-1031
Depends on: 1480198
Status: NEW → ASSIGNED
Priority: -- → P2
Attachment #9014847 - Attachment description: Bug 1496722 - Make nsIDocShellTreeItem.itemType readonly → Bug 1496722 - Make nsIDocShellTreeItem.itemType readonly.

Comment 5

•
8 months ago 
Pushed by afarre@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c428c8fc568
Make nsIDocShellTreeItem.itemType readonly. r=peterv

Comment 6

•
8 months ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/2c428c8fc568
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.