1496727 - use GetNextFile when iterating nsIDirectoryEnumerator in c-c

Status: RESOLVED FIXED

(MailNews Core :: Backend, enhancement)

Description

[:aceman]

nsIFile->GetDirectoryEntries() returns a nsIDirectoryEnumerator, which has a GetNextFile() that returns a nsIFile directly.

See e.g.
https://dxr.mozilla.org/comm-central/source/modules/libpref/Preferences.cpp#4638

Try to use this in c-c instead of the older dance via GetNext(nsISupports) and then QIing to a nsIFile:

while (NS_SUCCEEDED(rv) && NS_SUCCEEDED(children->HasMoreElements(&hasMore)) && hasMore) {
      nsCOMPtr<nsISupports> supports;
      rv = children->GetNext(getter_AddRefs(supports));
      NS_ENSURE_SUCCESS(rv, rv);
      nsCOMPtr<nsIFile> childFile = do_QueryInterface(supports, &rv);
      NS_ENSURE_SUCCESS(rv, rv);
}

Comment 1

[:aceman]

Attachment: 1496727.patch

This should do it.

Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=dbd4dbac41e6bfb0a0176357926de632a391cb26

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9014988 [details] [diff] [review]
1496727.patch

Wow, so much ugly code removed. And you wanted me to do a spot fix in bug 1496598 ;-) - Sadly your try run doesn't include Xpcshell tests, so that's were we would expect failures. Here's a new one:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=c89c1e5e592e5de6f26bc632a3dd4e05e524c3c2

Comment 3

[Jorg K (CEST = GMT+2)]

I don't think removing old crusty code and following the same pattern everywhere is trivial ;-)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a87795783553
use GetNextFile when iterating nsIDirectoryEnumerator in C-C. r=jorgk