Closed Bug 1496733 Opened Last year Closed Last year

./mach bootstrap is missing a dependency on FreeBSD

Categories

(Firefox Build System :: Bootstrap Configuration, defect)

Unspecified
FreeBSD
defect
Not set

Tracking

(firefox-esr60 fixed, firefox62 wontfix, firefox63 fixed, firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox-esr60 --- fixed
firefox62 --- wontfix
firefox63 --- fixed
firefox64 --- fixed

People

(Reporter: jbeich, Assigned: jbeich)

Details

(Whiteboard: [npotb])

Attachments

(1 file)

v1
884 bytes, patch
froydnj
: review+
Details | Diff | Splinter Review
One of the other dependencies probably stopped depending on libXt, so we need to list it explicitly. Tested inside pristine FreeBSD 12.0 amd64 jail.

$ ./mach bootstrap
$ ./mach build
[...]
 0:05.18 configure: error: Can't find X headers (install libxt-dev (Debian/Ubuntu), libXt-devel (Fedora), or xorg-x11-libXt-devel (SuSE)).
 0:05.19 DEBUG: <truncated - see config.log for full output>
 0:05.19 DEBUG: configure: failed program was:
 0:05.19 DEBUG: #line 14886 "configure"
 0:05.19 DEBUG: #include "confdefs.h"
 0:05.19 DEBUG:
 0:05.19 DEBUG:         #include <stdio.h>
 0:05.19 DEBUG:         #include <stdlib.h>
 0:05.19 DEBUG:         #include <X11/Xlib.h>
 0:05.19 DEBUG:         #include <X11/Intrinsic.h>
 0:05.19 DEBUG:         #include <X11/extensions/XShm.h>
 0:05.19 DEBUG:
 0:05.20 DEBUG: int main() {
 0:05.20 DEBUG:
 0:05.20 DEBUG:         Display *dpy = 0;
 0:05.20 DEBUG:         if ((dpy = XOpenDisplay(NULL)) == NULL) {
 0:05.20 DEBUG:             fprintf(stderr, ": can't open %s\n", XDisplayName(NULL));
 0:05.20 DEBUG:             exit(1);
 0:05.20 DEBUG:         }
 0:05.20 DEBUG:
 0:05.20 DEBUG: ; return 0; }
 0:05.20 DEBUG: configure: error: Can't find X headers (install libxt-dev (Debian/Ubuntu), libXt-devel (Fedora), or xorg-x11-libXt-devel (SuSE)).
 0:05.20 ERROR: old-configure failed
 0:05.22 *** Fix above errors and then restart with\
 0:05.22                "./mach build"
 0:05.22 gmake: *** [client.mk:128: configure] Error 1
Attached patch v1Splinter Review
Assignee: nobody → jbeich
Attachment #9014796 - Flags: review?(core-build-config-reviews)
Attachment #9014796 - Flags: review?(core-build-config-reviews) → review+
Keywords: checkin-needed
Comment on attachment 9014796 [details] [diff] [review]
v1

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: Broken build on FreeBSD after ./mach bootstrap.

Is this code covered by automated tests?: Unknown

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): ./mach bootstrap isn't used by the automation. If I'm wrong then assume this can only break build in case of syntax errors (e.g., missing quote).

String changes made/needed: 

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: Help get involved in porting Firefox to FreeBSD and build Firefox and, especially, projects based on ESR (e.g., Tor Browser, Thunderbird) outside of downstream build system in order check for regressions/differences.

User impact if declined: Broken build on FreeBSD after ./mach bootstrap.

Fix Landed on Version: 64

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): ./mach bootstrap isn't used by the automation. If I'm wrong then assume this can only break build in case of syntax errors (e.g., missing quote).

String or UUID changes made by this patch:
Attachment #9014796 - Flags: approval-mozilla-esr60?
Attachment #9014796 - Flags: approval-mozilla-beta?
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/410533a1241e
Explicitly install libXt on FreeBSD. r=Build r=froydnj
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/410533a1241e
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Comment on attachment 9014796 [details] [diff] [review]
v1

Sorry, this is too late in the Beta cycle (we build the last 63 beta on Thursday before entering RC) to uplift unplanned tier-3 patches as we need to minimize any potential regression for the final release.
Attachment #9014796 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Comment on attachment 9014796 [details] [diff] [review]
v1

Per IRC discussion, this patch is NPOTB and doesn't need approval for uplift. Sorry for the confusion :(
Attachment #9014796 - Flags: approval-mozilla-esr60?
Attachment #9014796 - Flags: approval-mozilla-beta-
You need to log in before you can comment on or make changes to this bug.